Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: ios/chrome/test/earl_grey/chrome_test_case.mm

Issue 2629733002: Create suffix to run more than one flaky EarlGrey target. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/test/earl_grey/chrome_test_case.mm
diff --git a/ios/chrome/test/earl_grey/chrome_test_case.mm b/ios/chrome/test/earl_grey/chrome_test_case.mm
index 1457fd7d6f0d0eadbfc5f5d84f3c231bdc379fd9..822d95b62ea23788073267a90abbadc1f3da4c4f 100644
--- a/ios/chrome/test/earl_grey/chrome_test_case.mm
+++ b/ios/chrome/test/earl_grey/chrome_test_case.mm
@@ -19,6 +19,8 @@
namespace {
+NSString* const kFlakyEarlGreyTestTargetSuffix = @"_flaky_egtests";
+
// Contains a list of test names that run in multitasking test suite.
NSArray* whiteListedMultitaskingTests = @[
// Integration tests
@@ -114,8 +116,8 @@ NSArray* whiteListedMultitaskingTests = @[
// Return specific list of tests based on the target.
NSString* targetName = [NSBundle mainBundle].infoDictionary[@"CFBundleName"];
- if ([targetName isEqualToString:@"ios_chrome_flaky_egtests"]) {
- // Only run FLAKY_ tests for the flaky test suite.
+ if ([targetName hasSuffix:kFlakyEarlGreyTestTargetSuffix]) {
+ // Only run FLAKY_ tests for flaky test suites.
return [self flakyTestNames];
} else if ([targetName isEqualToString:@"ios_chrome_multitasking_egtests"]) {
// Only run white listed tests for the multitasking test suite.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698