Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 2629683002: Revert of android: Remove DeviceDisplayInfo usage from ComopsitorImpl (Closed)

Created:
3 years, 11 months ago by mthiesse
Modified:
3 years, 11 months ago
Reviewers:
Tima Vaisburd, boliu
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of android: Remove DeviceDisplayInfo usage from ComopsitorImpl (patchset #2 id:20001 of https://codereview.chromium.org/2615793003/ ) Reason for revert: Crashes VrShell, can be re-landed after crbug.com/680150 is fixed. Original issue's description: > android: Remove DeviceDisplayInfo usage from ComopsitorImpl > > Use the window to get the correct display instead. > > BUG=625089 > > Review-Url: https://codereview.chromium.org/2615793003 > Cr-Commit-Position: refs/heads/master@{#442648} > Committed: https://chromium.googlesource.com/chromium/src/+/4868d4131b01a3e3520fcb2d65d9c5a1058a606a TBR=timav@chromium.org,boliu@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=625089

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M content/browser/renderer_host/compositor_impl_android.cc View 3 chunks +5 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mthiesse
Created Revert of android: Remove DeviceDisplayInfo usage from ComopsitorImpl
3 years, 11 months ago (2017-01-12 21:12:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629683002/1
3 years, 11 months ago (2017-01-12 21:12:36 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/99477)
3 years, 11 months ago (2017-01-12 21:34:31 UTC) #5
mthiesse
Seems this revert is non-trivial, going to see if I can speed up getting the ...
3 years, 11 months ago (2017-01-12 21:41:13 UTC) #6
boliu
3 years, 11 months ago (2017-01-12 21:44:58 UTC) #7
Message was sent while issue was closed.
On 2017/01/12 21:41:13, mthiesse wrote:
> Seems this revert is non-trivial, going to see if I can speed up getting the
fix
> landed instead.

you need to revert https://codereview.chromium.org/2623653002 as well

but yeah, if you already have the fix, why not land the fix?

Powered by Google App Engine
This is Rietveld 408576698