Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2615793003: android: Remove DeviceDisplayInfo usage from ComopsitorImpl (Closed)

Created:
3 years, 11 months ago by boliu
Modified:
3 years, 11 months ago
Reviewers:
Tima Vaisburd
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

android: Remove DeviceDisplayInfo usage from ComopsitorImpl Use the window to get the correct display instead. BUG=625089 Review-Url: https://codereview.chromium.org/2615793003 Cr-Commit-Position: refs/heads/master@{#442648} Committed: https://chromium.googlesource.com/chromium/src/+/4868d4131b01a3e3520fcb2d65d9c5a1058a606a

Patch Set 1 #

Total comments: 2

Patch Set 2 : const #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M content/browser/renderer_host/compositor_impl_android.cc View 1 3 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
boliu
ptal
3 years, 11 months ago (2017-01-06 00:45:19 UTC) #4
Tima Vaisburd
lgtm https://codereview.chromium.org/2615793003/diff/1/content/browser/renderer_host/compositor_impl_android.cc File content/browser/renderer_host/compositor_impl_android.cc (right): https://codereview.chromium.org/2615793003/diff/1/content/browser/renderer_host/compositor_impl_android.cc#newcode86 content/browser/renderer_host/compositor_impl_android.cc:86: gfx::Size size = display::Screen::GetScreen() nit: this |size| can ...
3 years, 11 months ago (2017-01-06 01:07:42 UTC) #5
boliu
https://codereview.chromium.org/2615793003/diff/1/content/browser/renderer_host/compositor_impl_android.cc File content/browser/renderer_host/compositor_impl_android.cc (right): https://codereview.chromium.org/2615793003/diff/1/content/browser/renderer_host/compositor_impl_android.cc#newcode86 content/browser/renderer_host/compositor_impl_android.cc:86: gfx::Size size = display::Screen::GetScreen() On 2017/01/06 01:07:42, Tima Vaisburd ...
3 years, 11 months ago (2017-01-06 01:23:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2615793003/20001
3 years, 11 months ago (2017-01-06 01:25:38 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/94932)
3 years, 11 months ago (2017-01-06 02:57:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2615793003/20001
3 years, 11 months ago (2017-01-10 18:30:24 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/4868d4131b01a3e3520fcb2d65d9c5a1058a606a
3 years, 11 months ago (2017-01-10 19:13:46 UTC) #16
mthiesse
3 years, 11 months ago (2017-01-12 21:12:13 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2629683002/ by mthiesse@chromium.org.

The reason for reverting is: Crashes VrShell, can be re-landed after
crbug.com/680150 is fixed..

Powered by Google App Engine
This is Rietveld 408576698