|
|
Created:
3 years, 11 months ago by boliu Modified:
3 years, 11 months ago Reviewers:
Tima Vaisburd CC:
chromium-reviews, jam, darin-cc_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionandroid: Remove DeviceDisplayInfo usage from ComopsitorImpl
Use the window to get the correct display instead.
BUG=625089
Review-Url: https://codereview.chromium.org/2615793003
Cr-Commit-Position: refs/heads/master@{#442648}
Committed: https://chromium.googlesource.com/chromium/src/+/4868d4131b01a3e3520fcb2d65d9c5a1058a606a
Patch Set 1 #
Total comments: 2
Patch Set 2 : const #Messages
Total messages: 17 (9 generated)
The CQ bit was checked by boliu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
boliu@chromium.org changed reviewers: + timav@chromium.org
ptal
lgtm https://codereview.chromium.org/2615793003/diff/1/content/browser/renderer_ho... File content/browser/renderer_host/compositor_impl_android.cc (right): https://codereview.chromium.org/2615793003/diff/1/content/browser/renderer_ho... content/browser/renderer_host/compositor_impl_android.cc:86: gfx::Size size = display::Screen::GetScreen() nit: this |size| can also be const
https://codereview.chromium.org/2615793003/diff/1/content/browser/renderer_ho... File content/browser/renderer_host/compositor_impl_android.cc (right): https://codereview.chromium.org/2615793003/diff/1/content/browser/renderer_ho... content/browser/renderer_host/compositor_impl_android.cc:86: gfx::Size size = display::Screen::GetScreen() On 2017/01/06 01:07:42, Tima Vaisburd wrote: > nit: this |size| can also be const Done.
The CQ bit was checked by boliu@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from timav@chromium.org Link to the patchset: https://codereview.chromium.org/2615793003/#ps20001 (title: "const")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by boliu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484072985342840, "parent_rev": "f380647990c63b5a258efba319f2aa1368b309f4", "commit_rev": "4868d4131b01a3e3520fcb2d65d9c5a1058a606a"}
Message was sent while issue was closed.
Description was changed from ========== android: Remove DeviceDisplayInfo usage from ComopsitorImpl Use the window to get the correct display instead. BUG=625089 ========== to ========== android: Remove DeviceDisplayInfo usage from ComopsitorImpl Use the window to get the correct display instead. BUG=625089 Review-Url: https://codereview.chromium.org/2615793003 Cr-Commit-Position: refs/heads/master@{#442648} Committed: https://chromium.googlesource.com/chromium/src/+/4868d4131b01a3e3520fcb2d65d9... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/4868d4131b01a3e3520fcb2d65d9...
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2629683002/ by mthiesse@chromium.org. The reason for reverting is: Crashes VrShell, can be re-landed after crbug.com/680150 is fixed.. |