Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2623653002: android: Remove DeviceDisplayInfo (Closed)

Created:
3 years, 11 months ago by boliu
Modified:
3 years, 11 months ago
CC:
agrieve+watch_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

android: Remove DeviceDisplayInfo Move getSmallestDIPWidth to ChromeContextUtil in chrome. This removes the last usage of DeviceDisplayInfo, so finally remove it. BUG=625089 Review-Url: https://codereview.chromium.org/2623653002 Cr-Commit-Position: refs/heads/master@{#442981} Committed: https://chromium.googlesource.com/chromium/src/+/21c5afa38918f95dd79a171a9d9d16c85ae4e9eb

Patch Set 1 #

Patch Set 2 : clean ups #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -606 lines) Patch
A chrome/android/java/src/org/chromium/chrome/browser/util/ChromeContextUtil.java View 1 1 chunk +20 lines, -0 lines 0 comments Download
M chrome/android/java_sources.gni View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
A chrome/browser/android/chrome_context_util.h View 1 1 chunk +23 lines, -0 lines 0 comments Download
A chrome/browser/android/chrome_context_util.cc View 1 1 chunk +22 lines, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 3 chunks +2 lines, -3 lines 0 comments Download
M ui/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ui/android/java/src/org/chromium/ui/display/DisplayAndroidManager.java View 4 chunks +0 lines, -7 lines 0 comments Download
D ui/android/java/src/org/chromium/ui/gfx/DeviceDisplayInfo.java View 1 chunk +0 lines, -221 lines 0 comments Download
M ui/gfx/BUILD.gn View 2 chunks +0 lines, -5 lines 0 comments Download
D ui/gfx/android/device_display_info.h View 1 1 chunk +0 lines, -65 lines 0 comments Download
D ui/gfx/android/device_display_info.cc View 1 chunk +0 lines, -54 lines 0 comments Download
M ui/gfx/android/gfx_jni_registrar.cc View 1 chunk +0 lines, -3 lines 0 comments Download
D ui/gfx/android/shared_device_display_info.h View 1 chunk +0 lines, -81 lines 0 comments Download
D ui/gfx/android/shared_device_display_info.cc View 1 chunk +0 lines, -166 lines 0 comments Download

Messages

Total messages: 34 (23 generated)
boliu
aelias for ui/gfx tedchoc for chrome and ui/android wee last one that removes DeviceDisplayInfo finally
3 years, 11 months ago (2017-01-10 23:12:23 UTC) #3
aelias_OOO_until_Jul13
lgtm
3 years, 11 months ago (2017-01-10 23:13:11 UTC) #6
Ted C
lgtm
3 years, 11 months ago (2017-01-10 23:14:56 UTC) #7
boliu
+sky to stamp chrome_content_browser_client.cc
3 years, 11 months ago (2017-01-10 23:23:48 UTC) #11
boliu
On 2017/01/10 23:23:48, boliu wrote: > +sky to stamp chrome_content_browser_client.cc Oh, wait, chrome_content_browser_client doesn't need ...
3 years, 11 months ago (2017-01-10 23:31:00 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2623653002/40001
3 years, 11 months ago (2017-01-10 23:33:12 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/97377)
3 years, 11 months ago (2017-01-11 01:16:17 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2623653002/40001
3 years, 11 months ago (2017-01-11 01:25:49 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/97627)
3 years, 11 months ago (2017-01-11 03:34:20 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2623653002/40001
3 years, 11 months ago (2017-01-11 19:22:39 UTC) #31
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 19:35:01 UTC) #34
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/21c5afa38918f95dd79a171a9d9d...

Powered by Google App Engine
This is Rietveld 408576698