Shape Detection: Remove ConstructorCallWith=Document

Shape Detection: Remove ConstructorCallWith=Document

This CL moves FaceDetection, BarcodeDetection and TextDetection registration
to render_process_host_impl.cc. Now they no longer depend on |LocalFrame| to
get the interfaces. FaceDetection Java interface is registered in //content,
and the other two are still in //chrome.

BUG=681231
SPEC=https://wicg.github.io/shape-detection-api/#api
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2629523008
Cr-Commit-Position: refs/heads/master@{#445083}
Committed: https://chromium.googlesource.com/chromium/src/+/5314b70c4d6d2ae4ed6c7719bc5ac68861409baa

[xianglu, 2017-01-12 22:39:13]

Description was changed from

==========
Shape Detection: Change Document to ExecutionContext for workers

BUG=
==========

to

==========
Shape Detection: Change Document to ExecutionContext for workers

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[xianglu, 2017-01-13 19:55:50]

Patchset #1 (id:1) has been deleted

[xianglu, 2017-01-13 19:55:58]

Patchset #1 (id:20001) has been deleted

[xianglu, 2017-01-13 23:16:52]

The CQ bit was checked by xianglu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 23:17:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xianglu, 2017-01-13 23:18:06]

Patchset #1 (id:40001) has been deleted

[xianglu, 2017-01-13 23:26:03]

The CQ bit was checked by xianglu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 23:26:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-14 00:01:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-14 00:01:31]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[xianglu, 2017-01-14 00:07:56]

The CQ bit was checked by xianglu@chromium.org to run a CQ dry run

[xianglu, 2017-01-14 00:08:18]

Patchset #1 (id:60001) has been deleted

[commit-bot: I haz the power, 2017-01-14 00:08:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xianglu, 2017-01-14 00:09:52]

Patchset #1 (id:80001) has been deleted

[xianglu, 2017-01-14 00:24:04]

Description was changed from

==========
Shape Detection: Change Document to ExecutionContext for workers

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Shape Detection: Change Document to ExecutionContext for workers

BUG=681231
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[xianglu, 2017-01-14 00:25:51]

Description was changed from

==========
Shape Detection: Change Document to ExecutionContext for workers

BUG=681231
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Shape Detection: Change ConstructorCallWith=Document to
ConstructorCallWith=ExecutionContext for workers

BUG=681231
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[xianglu, 2017-01-14 00:54:47]

Description was changed from

==========
Shape Detection: Change ConstructorCallWith=Document to
ConstructorCallWith=ExecutionContext for workers

BUG=681231
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Shape Detection: Change ConstructorCallWith=Document to ConstructorCallWith=
ExecutionContext for workers.

This CL moves FaceDetection, BarcodeDetection and TextDetection registration
to render_process_host_impl.cc. FaceDetection Java interface is registered in
/content, and the other two are still in //chrome.

BUG=681231
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[xianglu, 2017-01-14 01:00:53]

Description was changed from

==========
Shape Detection: Change ConstructorCallWith=Document to ConstructorCallWith=
ExecutionContext for workers.

This CL moves FaceDetection, BarcodeDetection and TextDetection registration
to render_process_host_impl.cc. FaceDetection Java interface is registered in
/content, and the other two are still in //chrome.

BUG=681231
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Shape Detection: Change ConstructorCallWith=Document to ConstructorCallWith=
ExecutionContext for workers.

This CL moves FaceDetection, BarcodeDetection and TextDetection registration
to render_process_host_impl.cc. Now they no longer depend on
|LocalFrame| to get the interfaces. FaceDetection Java interface
is registered in //content, and the other two are still in //chrome.

BUG=681231
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[xianglu, 2017-01-14 01:01:19]

Description was changed from

==========
Shape Detection: Change ConstructorCallWith=Document to ConstructorCallWith=
ExecutionContext for workers.

This CL moves FaceDetection, BarcodeDetection and TextDetection registration
to render_process_host_impl.cc. Now they no longer depend on
|LocalFrame| to get the interfaces. FaceDetection Java interface
is registered in //content, and the other two are still in //chrome.

BUG=681231
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Shape Detection: Change ConstructorCallWith=Document to ConstructorCallWith=
ExecutionContext for workers.

This CL moves FaceDetection, BarcodeDetection and TextDetection registration
to render_process_host_impl.cc. Now they no longer depend on |LocalFrame| to
get the interfaces. FaceDetection Java interface is registered in //content,
and the other two are still in //chrome.

BUG=681231
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[xianglu, 2017-01-14 01:03:01]

Description was changed from

==========
Shape Detection: Change ConstructorCallWith=Document to ConstructorCallWith=
ExecutionContext for workers.

This CL moves FaceDetection, BarcodeDetection and TextDetection registration
to render_process_host_impl.cc. Now they no longer depend on |LocalFrame| to
get the interfaces. FaceDetection Java interface is registered in //content,
and the other two are still in //chrome.

BUG=681231
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Shape Detection: Change ConstructorCallWith=Document to ConstructorCallWith=
ExecutionContext.

This CL moves FaceDetection, BarcodeDetection and TextDetection registration
to render_process_host_impl.cc. Now they no longer depend on |LocalFrame| to
get the interfaces. FaceDetection Java interface is registered in //content,
and the other two are still in //chrome.

BUG=681231
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[xianglu, 2017-01-14 01:30:22]

xianglu@chromium.org changed reviewers:
+ mcasas@chromium.org, rockot@chromium.org

[xianglu, 2017-01-14 01:30:23]

I'm moving three Shape Detection registrations to render_process_host_impl.cc,
so the renderer doesn't need a frame to get the interface. And workers would
work properly too. However, because Java implementation of BarcodeDetection and
TextDetection use Google Play Services, they need to be registered in //chrome.
So I'm a bit concerned about what would happen if someone only compiles
content_shell.

Ken, could you take a look at it please?

[commit-bot: I haz the power, 2017-01-14 03:25:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-14 03:25:38]

Dry run: This issue passed the CQ dry run.

[Reilly Grant (use Gerrit), 2017-01-17 19:51:46]

reillyg@chromium.org changed reviewers:
+ reillyg@chromium.org

[Reilly Grant (use Gerrit), 2017-01-17 19:51:47]

If the service is in the manifest but unimplemented by the browser process then
the renderer will simply observer a pipe closure and the connection error
handler will be called.

https://codereview.chromium.org/2629523008/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.cpp
(right):

https://codereview.chromium.org/2629523008/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.cpp:21:
BarcodeDetector::BarcodeDetector(ExecutionContext* executionContext)
This parameter is unused.

https://codereview.chromium.org/2629523008/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp (right):

https://codereview.chromium.org/2629523008/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp:23:
FaceDetector::FaceDetector(ExecutionContext* executionContext,
This parameter is unused.

https://codereview.chromium.org/2629523008/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp (right):

https://codereview.chromium.org/2629523008/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp:20:
TextDetector::TextDetector(ExecutionContext* executionContext)
This parameter is unused.

[Ken Rockot(use gerrit already), 2017-01-17 21:56:50]

On 2017/01/17 at 19:51:47, reillyg wrote:
> If the service is in the manifest but unimplemented by the browser process
then the renderer will simply observer a pipe closure and the connection error
handler will be called.

Correct. More specifically, the only requirement is that you always register a
binder in the C++-side InterfaceRegistry, which you do. If a request is passed
along to the Java InterfaceRegistry with no Java binder registered there (as
would be the case with shapedetection interfaces in content_shell), the request
will simply be dropped and the client code will eventually detect a connection
error.

Of course this does mean you can't possibly test shapedetection with layout
tests on Android, since layout tests run in content_shell. Is that OK?

> 
>
https://codereview.chromium.org/2629523008/diff/100001/third_party/WebKit/Sou...
> File third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.cpp
(right):
> 
>
https://codereview.chromium.org/2629523008/diff/100001/third_party/WebKit/Sou...
> third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.cpp:21:
BarcodeDetector::BarcodeDetector(ExecutionContext* executionContext)
> This parameter is unused.
> 
>
https://codereview.chromium.org/2629523008/diff/100001/third_party/WebKit/Sou...
> File third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp
(right):
> 
>
https://codereview.chromium.org/2629523008/diff/100001/third_party/WebKit/Sou...
> third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp:23:
FaceDetector::FaceDetector(ExecutionContext* executionContext,
> This parameter is unused.
> 
>
https://codereview.chromium.org/2629523008/diff/100001/third_party/WebKit/Sou...
> File third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp
(right):
> 
>
https://codereview.chromium.org/2629523008/diff/100001/third_party/WebKit/Sou...
> third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp:20:
TextDetector::TextDetector(ExecutionContext* executionContext)
> This parameter is unused.

[Ken Rockot(use gerrit already), 2017-01-17 21:57:25]

On 2017/01/17 at 21:56:50, Ken Rockot wrote:
> On 2017/01/17 at 19:51:47, reillyg wrote:
> > If the service is in the manifest but unimplemented by the browser process
then the renderer will simply observer a pipe closure and the connection error
handler will be called.
> 
> Correct. More specifically, the only requirement is that you always register a
binder in the C++-side InterfaceRegistry, which you do. If a request is passed
along to the Java InterfaceRegistry with no Java binder registered there (as
would be the case with shapedetection interfaces in content_shell), the request
will simply be dropped and the client code will eventually detect a connection
error.
> 
> Of course this does mean you can't possibly test shapedetection with layout
tests on Android, since layout tests run in content_shell. Is that OK?

Answering my own question: presumably it's OK because layout testing will want
to mock the service anyway.

> 
> > 
> >
https://codereview.chromium.org/2629523008/diff/100001/third_party/WebKit/Sou...
> > File third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.cpp
(right):
> > 
> >
https://codereview.chromium.org/2629523008/diff/100001/third_party/WebKit/Sou...
> > third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.cpp:21:
BarcodeDetector::BarcodeDetector(ExecutionContext* executionContext)
> > This parameter is unused.
> > 
> >
https://codereview.chromium.org/2629523008/diff/100001/third_party/WebKit/Sou...
> > File third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp
(right):
> > 
> >
https://codereview.chromium.org/2629523008/diff/100001/third_party/WebKit/Sou...
> > third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp:23:
FaceDetector::FaceDetector(ExecutionContext* executionContext,
> > This parameter is unused.
> > 
> >
https://codereview.chromium.org/2629523008/diff/100001/third_party/WebKit/Sou...
> > File third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp
(right):
> > 
> >
https://codereview.chromium.org/2629523008/diff/100001/third_party/WebKit/Sou...
> > third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp:20:
TextDetector::TextDetector(ExecutionContext* executionContext)
> > This parameter is unused.

[xianglu, 2017-01-17 23:03:07]

The CQ bit was checked by xianglu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 23:03:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 00:52:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 00:52:50]

Dry run: This issue passed the CQ dry run.

[xianglu, 2017-01-18 01:22:42]

On 2017/01/17 21:57:25, Ken Rockot wrote:
> On 2017/01/17 at 21:56:50, Ken Rockot wrote:
> > On 2017/01/17 at 19:51:47, reillyg wrote:
> > > If the service is in the manifest but unimplemented by the browser process
> then the renderer will simply observer a pipe closure and the connection error
> handler will be called.
> > 
> > Correct. More specifically, the only requirement is that you always register
a
> binder in the C++-side InterfaceRegistry, which you do. If a request is passed
> along to the Java InterfaceRegistry with no Java binder registered there (as
> would be the case with shapedetection interfaces in content_shell), the
request
> will simply be dropped and the client code will eventually detect a connection
> error.
> > 
> > Of course this does mean you can't possibly test shapedetection with layout
> tests on Android, since layout tests run in content_shell. Is that OK?
> 
> Answering my own question: presumably it's OK because layout testing will want
> to mock the service anyway.
> 
> > 
> > > 
> > >
>
https://codereview.chromium.org/2629523008/diff/100001/third_party/WebKit/Sou...
> > > File third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.cpp
> (right):
> > > 
> > >
>
https://codereview.chromium.org/2629523008/diff/100001/third_party/WebKit/Sou...
> > > third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.cpp:21:
> BarcodeDetector::BarcodeDetector(ExecutionContext* executionContext)
> > > This parameter is unused.
> > > 
> > >
>
https://codereview.chromium.org/2629523008/diff/100001/third_party/WebKit/Sou...
> > > File third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp
> (right):
> > > 
> > >
>
https://codereview.chromium.org/2629523008/diff/100001/third_party/WebKit/Sou...
> > > third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp:23:
> FaceDetector::FaceDetector(ExecutionContext* executionContext,
> > > This parameter is unused.
> > > 
> > >
>
https://codereview.chromium.org/2629523008/diff/100001/third_party/WebKit/Sou...
> > > File third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp
> (right):
> > > 
> > >
>
https://codereview.chromium.org/2629523008/diff/100001/third_party/WebKit/Sou...
> > > third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp:20:
> TextDetector::TextDetector(ExecutionContext* executionContext)
> > > This parameter is unused.

I see. In this CL layout tests should work since //services implementation is
still under review. And we would also add browser tests for barcode detection
and text detection later on.

[xianglu, 2017-01-18 01:26:50]

The CQ bit was checked by xianglu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 01:27:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xianglu, 2017-01-18 01:27:57]

Patchset #2 (id:120001) has been deleted

[xianglu, 2017-01-18 01:30:33]

Description was changed from

==========
Shape Detection: Change ConstructorCallWith=Document to ConstructorCallWith=
ExecutionContext.

This CL moves FaceDetection, BarcodeDetection and TextDetection registration
to render_process_host_impl.cc. Now they no longer depend on |LocalFrame| to
get the interfaces. FaceDetection Java interface is registered in //content,
and the other two are still in //chrome.

BUG=681231
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Shape Detection: Remove ConstructorCallWith=Document

This CL moves FaceDetection, BarcodeDetection and TextDetection registration
to render_process_host_impl.cc. Now they no longer depend on |LocalFrame| to
get the interfaces. FaceDetection Java interface is registered in //content,
and the other two are still in //chrome.

BUG=681231
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[xianglu, 2017-01-18 01:31:48]

Description was changed from

==========
Shape Detection: Remove ConstructorCallWith=Document

This CL moves FaceDetection, BarcodeDetection and TextDetection registration
to render_process_host_impl.cc. Now they no longer depend on |LocalFrame| to
get the interfaces. FaceDetection Java interface is registered in //content,
and the other two are still in //chrome.

BUG=681231
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Shape Detection: Remove ConstructorCallWith=Document

This CL moves FaceDetection, BarcodeDetection and TextDetection registration
to render_process_host_impl.cc. Now they no longer depend on |LocalFrame| to
get the interfaces. FaceDetection Java interface is registered in //content,
and the other two are still in //chrome.

BUG=681231
SPEC=
 https://wicg.github.io/shape-detection-api/#text-detection-api
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[xianglu, 2017-01-18 01:32:02]

Description was changed from

==========
Shape Detection: Remove ConstructorCallWith=Document

This CL moves FaceDetection, BarcodeDetection and TextDetection registration
to render_process_host_impl.cc. Now they no longer depend on |LocalFrame| to
get the interfaces. FaceDetection Java interface is registered in //content,
and the other two are still in //chrome.

BUG=681231
SPEC=
 https://wicg.github.io/shape-detection-api/#text-detection-api
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Shape Detection: Remove ConstructorCallWith=Document

This CL moves FaceDetection, BarcodeDetection and TextDetection registration
to render_process_host_impl.cc. Now they no longer depend on |LocalFrame| to
get the interfaces. FaceDetection Java interface is registered in //content,
and the other two are still in //chrome.

BUG=681231
SPEC=https://wicg.github.io/shape-detection-api/#text-detection-api
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[xianglu, 2017-01-18 01:32:28]

Description was changed from

==========
Shape Detection: Remove ConstructorCallWith=Document

This CL moves FaceDetection, BarcodeDetection and TextDetection registration
to render_process_host_impl.cc. Now they no longer depend on |LocalFrame| to
get the interfaces. FaceDetection Java interface is registered in //content,
and the other two are still in //chrome.

BUG=681231
SPEC=https://wicg.github.io/shape-detection-api/#text-detection-api
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Shape Detection: Remove ConstructorCallWith=Document

This CL moves FaceDetection, BarcodeDetection and TextDetection registration
to render_process_host_impl.cc. Now they no longer depend on |LocalFrame| to
get the interfaces. FaceDetection Java interface is registered in //content,
and the other two are still in //chrome.

BUG=681231
SPEC=https://wicg.github.io/shape-detection-api/#api
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[xianglu, 2017-01-18 01:37:10]

xianglu@chromium.org changed reviewers:
+ jochen@chromium.org, tsepez@chromium.org

[xianglu, 2017-01-18 01:37:10]

jochen@, please take a look at the whole CL.

tsepez@, please review *.json

[Reilly Grant (use Gerrit), 2017-01-18 01:53:03]

lgtm

[mcasas, 2017-01-18 02:05:10]

lgtm with an idea

https://codereview.chromium.org/2629523008/diff/140001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/shapedetection/TextDetectionFactory.java
(right):

https://codereview.chromium.org/2629523008/diff/140001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/shapedetection/TextDetectionFactory.java:25:
}
Hmm these Factory classes are so small, that we could
consider folding them into their respectives, to have:

public class TextDetectionImpl...

    public class Factory implements ...
        private final Context mContext;

        public Factory(Context context)

etc

then in the instantiation just do

registry.addInterface(
     BarcodeDetection.MANAGER, new
BarcodeDetection.Factory(applicationContext));


WDYT?

https://codereview.chromium.org/2629523008/diff/140001/chrome/browser/chrome_...
File chrome/browser/chrome_content_browser_client.cc (left):

https://codereview.chromium.org/2629523008/diff/140001/chrome/browser/chrome_...
chrome/browser/chrome_content_browser_client.cc:1449: defined(OS_ANDROID)
nit: is this your changes or a side effect of some
rebase?

[xianglu, 2017-01-18 02:22:31]

https://codereview.chromium.org/2629523008/diff/140001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/shapedetection/TextDetectionFactory.java
(right):

https://codereview.chromium.org/2629523008/diff/140001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/shapedetection/TextDetectionFactory.java:25:
}
On 2017/01/18 02:05:10, mcasas wrote:
> Hmm these Factory classes are so small, that we could
> consider folding them into their respectives, to have:
> 
> public class TextDetectionImpl...
> 
>     public class Factory implements ...
>         private final Context mContext;
> 
>         public Factory(Context context)
> 
> etc
> 
> then in the instantiation just do
> 
> registry.addInterface(
>      BarcodeDetection.MANAGER, new
> BarcodeDetection.Factory(applicationContext));
> 
> 
> WDYT?

Make sense. Will do in a follow-up CL, since this involves FaceDetection as
well.

https://codereview.chromium.org/2629523008/diff/140001/chrome/browser/chrome_...
File chrome/browser/chrome_content_browser_client.cc (left):

https://codereview.chromium.org/2629523008/diff/140001/chrome/browser/chrome_...
chrome/browser/chrome_content_browser_client.cc:1449: defined(OS_ANDROID)
On 2017/01/18 02:05:10, mcasas wrote:
> nit: is this your changes or a side effect of some
> rebase?

I removed this because otherwise AreExperimentalWebPlatformFeaturesEnabled()
will become an unused method when it's compiled on Android.

[commit-bot: I haz the power, 2017-01-18 02:59:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 02:59:56]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2017-01-18 12:28:07]

can you add a layout test that uses the different detectors from workers?

[Tom Sepez, 2017-01-18 18:02:47]

lgtm

[Ken Rockot(use gerrit already), 2017-01-19 19:57:01]

lgtm

[xianglu, 2017-01-20 02:47:49]

The CQ bit was checked by xianglu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 02:48:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xianglu, 2017-01-20 02:52:24]

The CQ bit was checked by xianglu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 02:52:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xianglu, 2017-01-20 02:53:07]

Patchset #3 (id:160001) has been deleted

[xianglu, 2017-01-20 02:58:41]

The CQ bit was checked by xianglu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 02:58:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xianglu, 2017-01-20 02:59:26]

Patchset #3 (id:180001) has been deleted

[xianglu, 2017-01-20 03:00:37]

jochen@ PTAL.

[commit-bot: I haz the power, 2017-01-20 04:16:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 04:16:44]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2017-01-20 07:29:56]

lgtm

[xianglu, 2017-01-20 17:21:16]

The CQ bit was checked by xianglu@chromium.org

[xianglu, 2017-01-20 17:21:17]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
rockot@chromium.org, mcasas@chromium.org, reillyg@chromium.org
Link to the patchset: https://codereview.chromium.org/2629523008/#ps200001
(title: "Add layout test for worker")

[commit-bot: I haz the power, 2017-01-20 17:21:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 17:26:18]

CQ is committing da patch.

Bot data: {"patchset_id": 200001, "attempt_start_ts": 1484932876343500,
"parent_rev": "b96d1720dea7398e82dd068fc88619c9df06b5a4", "commit_rev":
"5314b70c4d6d2ae4ed6c7719bc5ac68861409baa"}

[commit-bot: I haz the power, 2017-01-20 17:26:52]

Description was changed from

==========
Shape Detection: Remove ConstructorCallWith=Document

This CL moves FaceDetection, BarcodeDetection and TextDetection registration
to render_process_host_impl.cc. Now they no longer depend on |LocalFrame| to
get the interfaces. FaceDetection Java interface is registered in //content,
and the other two are still in //chrome.

BUG=681231
SPEC=https://wicg.github.io/shape-detection-api/#api
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Shape Detection: Remove ConstructorCallWith=Document

This CL moves FaceDetection, BarcodeDetection and TextDetection registration
to render_process_host_impl.cc. Now they no longer depend on |LocalFrame| to
get the interfaces. FaceDetection Java interface is registered in //content,
and the other two are still in //chrome.

BUG=681231
SPEC=https://wicg.github.io/shape-detection-api/#api
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2629523008
Cr-Commit-Position: refs/heads/master@{#445083}
Committed:
https://chromium.googlesource.com/chromium/src/+/5314b70c4d6d2ae4ed6c7719bc5a...
==========

[commit-bot: I haz the power, 2017-01-20 17:26:54]

Committed patchset #3 (id:200001) as
https://chromium.googlesource.com/chromium/src/+/5314b70c4d6d2ae4ed6c7719bc5a...