Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Side by Side Diff: third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp

Issue 2629523008: Shape Detection: Remove ConstructorCallWith=Document (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/shapedetection/FaceDetector.h" 5 #include "modules/shapedetection/FaceDetector.h"
6 6
7 #include "core/dom/DOMException.h" 7 #include "core/dom/DOMException.h"
8 #include "core/dom/DOMRect.h" 8 #include "core/dom/DOMRect.h"
9 #include "core/frame/LocalFrame.h"
10 #include "core/html/canvas/CanvasImageSource.h" 9 #include "core/html/canvas/CanvasImageSource.h"
11 #include "modules/shapedetection/DetectedFace.h" 10 #include "modules/shapedetection/DetectedFace.h"
12 #include "modules/shapedetection/FaceDetectorOptions.h" 11 #include "modules/shapedetection/FaceDetectorOptions.h"
13 #include "public/platform/InterfaceProvider.h" 12 #include "public/platform/InterfaceProvider.h"
13 #include "public/platform/Platform.h"
14 #include "services/shape_detection/public/interfaces/facedetection_provider.mojo m-blink.h" 14 #include "services/shape_detection/public/interfaces/facedetection_provider.mojo m-blink.h"
15 15
16 namespace blink { 16 namespace blink {
17 17
18 FaceDetector* FaceDetector::create(Document& document, 18 FaceDetector* FaceDetector::create(ExecutionContext* executionContext,
19 const FaceDetectorOptions& options) { 19 const FaceDetectorOptions& options) {
20 return new FaceDetector(*document.frame(), options); 20 return new FaceDetector(executionContext, options);
21 } 21 }
22 22
23 FaceDetector::FaceDetector(LocalFrame& frame, 23 FaceDetector::FaceDetector(ExecutionContext* executionContext,
Reilly Grant (use Gerrit) 2017/01/17 19:51:47 This parameter is unused.
24 const FaceDetectorOptions& options) 24 const FaceDetectorOptions& options)
25 : ShapeDetector(frame) { 25 : ShapeDetector() {
26 shape_detection::mojom::blink::FaceDetectorOptionsPtr faceDetectorOptions = 26 shape_detection::mojom::blink::FaceDetectorOptionsPtr faceDetectorOptions =
27 shape_detection::mojom::blink::FaceDetectorOptions::New(); 27 shape_detection::mojom::blink::FaceDetectorOptions::New();
28 faceDetectorOptions->max_detected_faces = options.maxDetectedFaces(); 28 faceDetectorOptions->max_detected_faces = options.maxDetectedFaces();
29 faceDetectorOptions->fast_mode = options.fastMode(); 29 faceDetectorOptions->fast_mode = options.fastMode();
30 shape_detection::mojom::blink::FaceDetectionProviderPtr provider; 30 shape_detection::mojom::blink::FaceDetectionProviderPtr provider;
31 frame.interfaceProvider()->getInterface(mojo::MakeRequest(&provider)); 31 Platform::current()->interfaceProvider()->getInterface(
32 mojo::MakeRequest(&provider));
32 provider->CreateFaceDetection(mojo::MakeRequest(&m_faceService), 33 provider->CreateFaceDetection(mojo::MakeRequest(&m_faceService),
33 std::move(faceDetectorOptions)); 34 std::move(faceDetectorOptions));
34 35
35 m_faceService.set_connection_error_handler(convertToBaseCallback(WTF::bind( 36 m_faceService.set_connection_error_handler(convertToBaseCallback(WTF::bind(
36 &FaceDetector::onFaceServiceConnectionError, wrapWeakPersistent(this)))); 37 &FaceDetector::onFaceServiceConnectionError, wrapWeakPersistent(this))));
37 } 38 }
38 39
39 ScriptPromise FaceDetector::doDetect( 40 ScriptPromise FaceDetector::doDetect(
40 ScriptPromiseResolver* resolver, 41 ScriptPromiseResolver* resolver,
41 mojo::ScopedSharedBufferHandle sharedBufferHandle, 42 mojo::ScopedSharedBufferHandle sharedBufferHandle,
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 m_faceServiceRequests.clear(); 80 m_faceServiceRequests.clear();
80 m_faceService.reset(); 81 m_faceService.reset();
81 } 82 }
82 83
83 DEFINE_TRACE(FaceDetector) { 84 DEFINE_TRACE(FaceDetector) {
84 ShapeDetector::trace(visitor); 85 ShapeDetector::trace(visitor);
85 visitor->trace(m_faceServiceRequests); 86 visitor->trace(m_faceServiceRequests);
86 } 87 }
87 88
88 } // namespace blink 89 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698