Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2629493002: Revert of [crankshaft] Also inline Math.ceil. (Closed)

Created:
3 years, 11 months ago by adamk
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [crankshaft] Also inline Math.ceil. (patchset #1 id:1 of https://codereview.chromium.org/2621903002/ ) Reason for revert: Suspected of causing crashes on Canary: https://crbug.com/680108 Original issue's description: > [crankshaft] Also inline Math.ceil. > > Inline calls to Math.ceil(x) as -Math.floor(-x) via the existing fast > path in Crankshaft. > > R=ishell@chromium.org > BUG=v8:5782 > > Review-Url: https://codereview.chromium.org/2621903002 > Cr-Commit-Position: refs/heads/master@{#42161} > Committed: https://chromium.googlesource.com/v8/v8/+/a3859e48c3c5c1c4f8a0c76b65a389b6063eba89 TBR=ishell@chromium.org,bmeurer@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:5782, chromium:680108 Review-Url: https://codereview.chromium.org/2629493002 Cr-Commit-Position: refs/heads/master@{#42247} Committed: https://chromium.googlesource.com/v8/v8/+/f056905fcc15a5a736b87e3a5bad437f087c3172

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -34 lines) Patch
M src/crankshaft/hydrogen.cc View 2 chunks +0 lines, -34 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
adamk
Created Revert of [crankshaft] Also inline Math.ceil.
3 years, 11 months ago (2017-01-11 22:08:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629493002/1
3 years, 11 months ago (2017-01-11 22:10:02 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 22:38:04 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/f056905fcc15a5a736b87e3a5bad437f087...

Powered by Google App Engine
This is Rietveld 408576698