Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 2621903002: [crankshaft] Also inline Math.ceil. (Closed)

Created:
3 years, 11 months ago by Benedikt Meurer
Modified:
3 years, 11 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Also inline Math.ceil. Inline calls to Math.ceil(x) as -Math.floor(-x) via the existing fast path in Crankshaft. R=ishell@chromium.org BUG=v8:5782 Review-Url: https://codereview.chromium.org/2621903002 Cr-Commit-Position: refs/heads/master@{#42161} Committed: https://chromium.googlesource.com/v8/v8/+/a3859e48c3c5c1c4f8a0c76b65a389b6063eba89

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
M src/crankshaft/hydrogen.cc View 2 chunks +34 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Benedikt Meurer
3 years, 11 months ago (2017-01-10 08:07:47 UTC) #1
Igor Sheludko
lgtm
3 years, 11 months ago (2017-01-10 08:19:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2621903002/1
3 years, 11 months ago (2017-01-10 08:20:22 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/a3859e48c3c5c1c4f8a0c76b65a389b6063eba89
3 years, 11 months ago (2017-01-10 08:33:56 UTC) #10
adamk
3 years, 11 months ago (2017-01-11 22:08:50 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2629493002/ by adamk@chromium.org.

The reason for reverting is: Suspected of causing crashes on Canary:
https://crbug.com/680108.

Powered by Google App Engine
This is Rietveld 408576698