Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issue 2629253003: [Merge to M56] Updating the CLD3 commit hash in DEPS (Closed)

Created:
3 years, 11 months ago by groby-ooo-7-16
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

[Merge to M56] Updating the CLD3 commit hash in DEPS The main change is static_cast-ing a few chars in ported code to unsigned chars because on some platforms by default char is signed, on others it's unsigned. GitHub page showing the diff: https://github.com/google/cld3/commit/ae02d6b8a2af41e87c956c7c7d3f651a8b7b9e79 BUG= Review-Url: https://codereview.chromium.org/2627143002 Cr-Commit-Position: refs/heads/master@{#443146} (cherry picked from commit c0f8f84b557b561608a44be21c14086c88caceda) Review-Url: https://codereview.chromium.org/2629253003 . Cr-Commit-Position: refs/branch-heads/2924@{#761} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/474d92b55d12abfd3ae8b25024f3c56c909066a0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
groby-ooo-7-16
3 years, 11 months ago (2017-01-13 18:48:47 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
474d92b55d12abfd3ae8b25024f3c56c909066a0.

Powered by Google App Engine
This is Rietveld 408576698