Updating the CLD3 commit hash in DEPS

Updating the CLD3 commit hash in DEPS

The main change is static_cast-ing a few chars in ported code to 
unsigned chars because on some platforms by default char is signed, 
on others it's unsigned.

GitHub page showing the diff:
https://github.com/google/cld3/commit/ae02d6b8a2af41e87c956c7c7d3f651a8b7b9e79

BUG=

Review-Url: https://codereview.chromium.org/2627143002
Cr-Commit-Position: refs/heads/master@{#443146}
Committed: https://chromium.googlesource.com/chromium/src/+/c0f8f84b557b561608a44be21c14086c88caceda

[Anton Bakalov, 2017-01-11 21:39:17]

The CQ bit was checked by abakalov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 21:40:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Anton Bakalov, 2017-01-11 22:29:25]

Description was changed from

==========
Updating the CLD3 commit hash in DEPS

BUG=
==========

to

==========
Updating the CLD3 commit hash in DEPS

The main change is static_cast-ing a few chars in ported code to 
unsigned chars because on some platforms by default char is signed, 
on others it's unsigned.

GitHub page showing the diff:
https://github.com/google/cld3/commit/ae02d6b8a2af41e87c956c7c7d3f651a8b7b9e79

BUG=
==========

[Anton Bakalov, 2017-01-11 22:30:58]

abakalov@chromium.org changed reviewers:
+ groby@chromium.org, rouslan@chromium.org

[commit-bot: I haz the power, 2017-01-11 23:12:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 23:12:42]

Dry run: This issue passed the CQ dry run.

[groby-ooo-7-16, 2017-01-12 02:37:14]

On 2017/01/11 22:30:59, Anton Bakalov wrote:

LGTM, so we can quickly get a fix in - but do you think it'd make sense to add
some test coverage for CLD in Chromium?

[Anton Bakalov, 2017-01-12 03:25:49]

On 2017/01/12 02:37:14, groby wrote:
> On 2017/01/11 22:30:59, Anton Bakalov wrote:
> 
> LGTM, so we can quickly get a fix in - but do you think it'd make sense to add
> some test coverage for CLD in Chromium?

Thanks Rachel! I totally agree with you. In the internal repository we have
tests but in that codebase everything is fine in terms of char signedness, so
this issue wasn't caught. I was hoping to have some of the bots run unit tests
for CLD3 but I was told at the beginning of the project that bots don't check
third_party code. But we can add more integration tests. The ones that tested
CLD2, test CLD3 as well but they check a subset of the supported languages. We
can write additional ones, so that all languages are covered. Please let me know
if you have any other suggestions.

[Anton Bakalov, 2017-01-12 03:44:59]

The CQ bit was checked by abakalov@chromium.org

[commit-bot: I haz the power, 2017-01-12 03:45:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 03:59:24]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484192699376640, "parent_rev":
"25e6b9fd5ed8e45a96b63d98bf793e931db2fa20", "commit_rev":
"c0f8f84b557b561608a44be21c14086c88caceda"}

[commit-bot: I haz the power, 2017-01-12 03:59:58]

Description was changed from

==========
Updating the CLD3 commit hash in DEPS

The main change is static_cast-ing a few chars in ported code to 
unsigned chars because on some platforms by default char is signed, 
on others it's unsigned.

GitHub page showing the diff:
https://github.com/google/cld3/commit/ae02d6b8a2af41e87c956c7c7d3f651a8b7b9e79

BUG=
==========

to

==========
Updating the CLD3 commit hash in DEPS

The main change is static_cast-ing a few chars in ported code to 
unsigned chars because on some platforms by default char is signed, 
on others it's unsigned.

GitHub page showing the diff:
https://github.com/google/cld3/commit/ae02d6b8a2af41e87c956c7c7d3f651a8b7b9e79

BUG=

Review-Url: https://codereview.chromium.org/2627143002
Cr-Commit-Position: refs/heads/master@{#443146}
Committed:
https://chromium.googlesource.com/chromium/src/+/c0f8f84b557b561608a44be21c14...
==========

[commit-bot: I haz the power, 2017-01-12 03:59:59]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c0f8f84b557b561608a44be21c14...