Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2629233003: Revert of Change the keyboard bounds when moving to another display. (Closed)

Created:
3 years, 11 months ago by xlai (Olivia)
Modified:
3 years, 11 months ago
Reviewers:
bshe, yhanada
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Change the keyboard bounds when moving to another display. (patchset #3 id:40001 of https://codereview.chromium.org/2620273002/ ) Reason for revert: This CL is causing Win10 Tests x64 to fail keyboard_unittests on windows-10-10586 https://build.chromium.org/p/chromium.win/builders/Win10%20Tests%20x64/builds/7528 Original issue's description: > Change the keyboard bounds when moving to another display. > > BUG=303429 > TEST=Manual test by the instruction described in the issue. > > Review-Url: https://codereview.chromium.org/2620273002 > Cr-Commit-Position: refs/heads/master@{#443382} > Committed: https://chromium.googlesource.com/chromium/src/+/28bbd7f5406de93446143d93f4b8056267ef8fbf TBR=bshe@chromium.org,yhanada@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=303429 Review-Url: https://codereview.chromium.org/2629233003 Cr-Commit-Position: refs/heads/master@{#443566} Committed: https://chromium.googlesource.com/chromium/src/+/a666bfa644b0f991852c56ec78074ee738a44c7e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -57 lines) Patch
M ui/keyboard/keyboard_controller.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/keyboard/keyboard_controller.cc View 3 chunks +8 lines, -19 lines 0 comments Download
M ui/keyboard/keyboard_controller_unittest.cc View 2 chunks +1 line, -34 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
xlai (Olivia)
Created Revert of Change the keyboard bounds when moving to another display.
3 years, 11 months ago (2017-01-13 16:01:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629233003/1
3 years, 11 months ago (2017-01-13 16:02:20 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 16:03:28 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a666bfa644b0f991852c56ec7807...

Powered by Google App Engine
This is Rietveld 408576698