Change the keyboard bounds when moving to another display.

Change the keyboard bounds when moving to another display.

BUG=303429
TEST=Manual test by the instruction described in the issue.

Review-Url: https://codereview.chromium.org/2620273002
Cr-Commit-Position: refs/heads/master@{#443382}
Committed: https://chromium.googlesource.com/chromium/src/+/28bbd7f5406de93446143d93f4b8056267ef8fbf

[yhanada, 2017-01-11 05:52:52]

The CQ bit was checked by yhanada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 05:53:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhanada, 2017-01-11 06:54:15]

The CQ bit was checked by yhanada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 06:54:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 07:41:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 07:41:39]

Dry run: This issue passed the CQ dry run.

[yhanada, 2017-01-11 07:42:10]

yhanada@chromium.org changed reviewers:
+ bshe@chromium.org

[yhanada, 2017-01-11 07:42:11]

Hi bshe@, PTAL. Thanks!

[bshe, 2017-01-11 14:37:35]

can you add a unit test if possible?

https://codereview.chromium.org/2620273002/diff/20001/ui/keyboard/keyboard_co...
File ui/keyboard/keyboard_controller.cc (right):

https://codereview.chromium.org/2620273002/diff/20001/ui/keyboard/keyboard_co...
ui/keyboard/keyboard_controller.cc:509: if (keyboard_mode_ == FLOATING) {
nit: if (keyboard_mode == FLOATING) return;

[yhanada, 2017-01-12 13:01:32]

The CQ bit was checked by yhanada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 13:01:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 13:43:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 13:43:19]

Dry run: This issue passed the CQ dry run.

[yhanada, 2017-01-12 14:26:11]

I added a unit test. Please take another look.

https://codereview.chromium.org/2620273002/diff/20001/ui/keyboard/keyboard_co...
File ui/keyboard/keyboard_controller.cc (right):

https://codereview.chromium.org/2620273002/diff/20001/ui/keyboard/keyboard_co...
ui/keyboard/keyboard_controller.cc:509: if (keyboard_mode_ == FLOATING) {
On 2017/01/11 14:37:35, bshe wrote:
> nit: if (keyboard_mode == FLOATING) return;

Done.

[bshe, 2017-01-12 16:45:15]

On 2017/01/12 14:26:11, yhanada wrote:
> I added a unit test. Please take another look.
> 
>
https://codereview.chromium.org/2620273002/diff/20001/ui/keyboard/keyboard_co...
> File ui/keyboard/keyboard_controller.cc (right):
> 
>
https://codereview.chromium.org/2620273002/diff/20001/ui/keyboard/keyboard_co...
> ui/keyboard/keyboard_controller.cc:509: if (keyboard_mode_ == FLOATING) {
> On 2017/01/11 14:37:35, bshe wrote:
> > nit: if (keyboard_mode == FLOATING) return;
> 
> Done.

lgtm

[yhanada, 2017-01-12 22:01:39]

Thank you for the review.

[yhanada, 2017-01-12 22:01:45]

The CQ bit was checked by yhanada@chromium.org

[commit-bot: I haz the power, 2017-01-12 22:03:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 22:10:19]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484258505513160,
"parent_rev": "25b12b9767399f5a29cb74e20cc9e7fa64cc532c", "commit_rev":
"28bbd7f5406de93446143d93f4b8056267ef8fbf"}

[commit-bot: I haz the power, 2017-01-12 22:10:49]

Description was changed from

==========
Change the keyboard bounds when moving to another display.

BUG=303429
TEST=Manual test by the instruction described in the issue.
==========

to

==========
Change the keyboard bounds when moving to another display.

BUG=303429
TEST=Manual test by the instruction described in the issue.

Review-Url: https://codereview.chromium.org/2620273002
Cr-Commit-Position: refs/heads/master@{#443382}
Committed:
https://chromium.googlesource.com/chromium/src/+/28bbd7f5406de93446143d93f4b8...
==========

[commit-bot: I haz the power, 2017-01-12 22:10:50]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/28bbd7f5406de93446143d93f4b8...

[xlai (Olivia), 2017-01-13 16:01:25]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2629233003/ by xlai@chromium.org.

The reason for reverting is: This CL is causing Win10 Tests x64 to fail
keyboard_unittests on windows-10-10586

https://build.chromium.org/p/chromium.win/builders/Win10%20Tests%20x64/builds....