Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2629203002: Remove TODOs and update method comments (Closed)

Created:
3 years, 11 months ago by Nate Fischer
Modified:
3 years, 11 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove TODOs and update method comments TODOs have been removed since we are no longer componentizing SafeBrowsingService and are not yet supporting reporting in WebView. Comments for the base class methods have been updated to indicate these methods are no-ops, but describe how they should be overridden. BUG=488675 Review-Url: https://codereview.chromium.org/2629203002 Cr-Commit-Position: refs/heads/master@{#443383} Committed: https://chromium.googlesource.com/chromium/src/+/54471efa0988e7663f29738c3b76576c48e085e1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M components/safe_browsing/base_ui_manager.h View 3 chunks +9 lines, -7 lines 0 comments Download
M components/safe_browsing/base_ui_manager.cc View 3 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Nate Fischer
No change in logic. This only updates comments as requested in https://bugs.chromium.org/p/chromium/issues/detail?id=488675#c27 sgurun@: is this ...
3 years, 11 months ago (2017-01-12 20:22:04 UTC) #5
Jialiu Lin
lgtm. Defer to sgurun@ for final approval.
3 years, 11 months ago (2017-01-12 20:37:30 UTC) #6
sgurun-gerrit only
lgtm
3 years, 11 months ago (2017-01-12 20:42:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629203002/1
3 years, 11 months ago (2017-01-12 22:07:31 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 22:17:32 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/54471efa0988e7663f29738c3b76...

Powered by Google App Engine
This is Rietveld 408576698