Remove TODOs and update method comments

components/safe_browsing/base_ui_manager.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_SAFE_BROWSING_BASE_UI_MANAGER_H_
 #define COMPONENTS_SAFE_BROWSING_BASE_UI_MANAGER_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 20 matching lines @@
 class BaseUIManager
     : public base::RefCountedThreadSafe<BaseUIManager> {
  public:
   typedef security_interstitials::UnsafeResource UnsafeResource;
 
   BaseUIManager();
 
   // Called to stop or shutdown operations on the io_thread. This may be called
   // multiple times during the life of the UIManager. Should be called
   // on IO thread. If shutdown is true, the manager is disabled permanently.
+  // This currently is a no-op in the base class.
   virtual void StopOnIOThread(bool shutdown);
 
   // Called on the UI thread to display an interstitial page.
   // |url| is the url of the resource that matches a safe browsing list.
   // If the request contained a chain of redirects, |url| is the last url
   // in the chain, and |original_url| is the first one (the root of the
   // chain). Otherwise, |original_url| = |url|.
   virtual void DisplayBlockingPage(const UnsafeResource& resource);
 
   // Log the user perceived delay caused by SafeBrowsing. This delay is the time
   // delta starting from when we would have started reading data from the
   // network, and ending when the SafeBrowsing check completes indicating that
   // the current page is 'safe'.
   virtual void LogPauseDelay(base::TimeDelta time);
 
-  // Called on the IO thread by the ThreatDetails with the serialized
-  // protocol buffer, so the service can send it over.
+  // This is a no-op in the base class, but should be overridden to send threat
+  // details. Called on the IO thread by the ThreatDetails with the serialized
+  // protocol buffer.
   virtual void SendSerializedThreatDetails(const std::string& serialized);
 
-  // Report hits to the unsafe contents (malware, phishing, unsafe download URL)
-  // to the server. Can only be called on UI thread.  If |post_data| is
-  // non-empty, the request will be sent as a POST instead of a GET.
-  // Will report only for UMA || is_extended_reporting.
+  // This is a no-op in the base class, but should be overridden to report hits
+  // to the unsafe contents (malware, phishing, unsafe download URL)
+  // to the server. Can only be called on UI thread.
   virtual void MaybeReportSafeBrowsingHit(
       const safe_browsing::HitReport& hit_report);
 
   // A convenience wrapper method for IsUrlWhitelistedOrPendingForWebContents.
   virtual bool IsWhitelisted(const UnsafeResource& resource);
 
   // Checks if we already displayed or are displaying an interstitial
   // for the top-level site |url| in a given WebContents. If
   // |whitelist_only|, it returns true only if the user chose to ignore
   // the interstitial. Otherwise, it returns true if an interstitial for
@@ skipping 36 matching lines @@
 
  protected:
   virtual ~BaseUIManager();
 
   // Updates the whitelist URL set for |web_contents|. Called on the UI thread.
   void AddToWhitelistUrlSet(const GURL& whitelist_url,
                             content::WebContents* web_contents,
                             bool is_pending,
                             SBThreatType threat_type);
 
-  // Call protocol manager on IO thread to report hits of unsafe contents.
+  // This is a no-op that should be overridden to call protocol manager on IO
+  // thread to report hits of unsafe contents.
   virtual void ReportSafeBrowsingHitOnIOThread(
       const safe_browsing::HitReport& hit_report);
 
   // Removes |whitelist_url| from the pending whitelist for
   // |web_contents|. Called on the UI thread.
   void RemoveFromPendingWhitelistUrlSet(const GURL& whitelist_url,
                                         content::WebContents* web_contents);
 
   // Ensures that |web_contents| has its whitelist set in its userdata
   static void EnsureWhitelistCreated(content::WebContents* web_contents);
 
   // Returns the URL that should be used in a WhitelistUrlSet for the given
   // |resource|.
   static GURL GetMainFrameWhitelistUrlForResource(
       const security_interstitials::UnsafeResource& resource);
 
  private:
   friend class base::RefCountedThreadSafe<BaseUIManager>;
 
   DISALLOW_COPY_AND_ASSIGN(BaseUIManager);
 };
 
 }  // namespace safe_browsing
 
 #endif  // COMPONENTS_SAFE_BROWSING_BASE_UI_MANAGER_H_