Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/namer.dart

Issue 26291005: dart2js: The name of a library without a library declaration is the empty string. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/js_backend/namer.dart
diff --git a/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart b/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart
index f11ac3be014f6f8802e9e12069e67d010c32e3bb..0c4ba86a97f4da5e6cb8808d70bda541bb06faf8 100644
--- a/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart
+++ b/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart
@@ -583,7 +583,7 @@ class Namer implements ClosureNamer {
}
} else if (element.isLibrary()) {
LibraryElement library = element;
- name = library.getLibraryOrScriptName();
+ name = library.getLibraryName();
ahe 2013/10/10 11:47:53 This change doesn't seem correct, as this method m
if (name.contains('.')) {
// For libraries that have a library tag, we use the last part
// of the fully qualified name as their base name. For all other
@@ -841,7 +841,7 @@ class Namer implements ClosureNamer {
return 'P';
}
return userGlobalObjects[
- library.getLibraryOrScriptName().hashCode % userGlobalObjects.length];
+ library.getLibraryName().hashCode % userGlobalObjects.length];
ahe 2013/10/10 11:47:53 I think we need to keep getLibraryOrScriptName. Ot
}
jsAst.PropertyAccess elementAccess(Element element) {

Powered by Google App Engine
This is Rietveld 408576698