sdk/lib/_internal/lib/js_mirrors.dart - Issue 26291005: dart2js: The name of a library without a library declaration is the empty string.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/lib/js_mirrors.dart

Issue 26291005: dart2js: The name of a library without a library declaration is the empty string. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/js_backend/namer.dart ('K') | « sdk/lib/_internal/compiler/implementation/typechecker.dart ('k') | tests/lib/lib.status » ('j') | tests/lib/mirrors/unnamed_library_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/lib/js_mirrors.dart

diff --git a/sdk/lib/_internal/lib/js_mirrors.dart b/sdk/lib/_internal/lib/js_mirrors.dart

index 4d0fe517fc221b9a484387446e254ede35b54dcb..bc62f9d7ced745d17a2ea2c6bbf71cbb0d662e71 100644

--- a/sdk/lib/_internal/lib/js_mirrors.dart

+++ b/sdk/lib/_internal/lib/js_mirrors.dart

@@ -1808,7 +1808,6 @@ TypeMirror typeMirrorFromRuntimeTypeRepresentation(type) {

Symbol computeQualifiedName(DeclarationMirror owner, Symbol simpleName) {

if (owner == null) return simpleName;

String ownerName = n(owner.qualifiedName);

- if (ownerName == '') return simpleName;

ahe 2013/10/10 11:47:53 This change does not make sense to me.

return s('$ownerName.${n(simpleName)}');

}