dart2js: The name of a library without a library declaration is the empty string.

sdk/lib/_internal/compiler/implementation/js_backend/namer.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of js_backend;
 
 /**
  * Assigns JavaScript identifiers to Dart variables, class-names and members.
  */
 class Namer implements ClosureNamer {
@@ skipping 565 matching lines @@
     } else if (Elements.isStaticOrTopLevel(element)) {
       if (element.isMember()) {
         ClassElement enclosingClass = element.getEnclosingClass();
         name = "${enclosingClass.name.slowToString()}_"
                "${element.name.slowToString()}";
       } else {
         name = element.name.slowToString().replaceAll('+', '_');
       }
     } else if (element.isLibrary()) {
       LibraryElement library = element;
-      name = library.getLibraryOrScriptName();
+      name = library.getLibraryName();

[ahe, 2013/10/10 11:47:53]

This change doesn't seem correct, as this method might now return an empty
string.

       if (name.contains('.')) {
         // For libraries that have a library tag, we use the last part
         // of the fully qualified name as their base name. For all other
         // libraries, we use the first part of their filename.
         name = library.hasLibraryName()
             ? name.substring(name.lastIndexOf('.') + 1)
             : name.substring(0, name.indexOf('.'));
       }
     } else {
       name = element.name.slowToString();
@@ skipping 237 matching lines @@
   String globalObjectFor(Element element) {
     if (isPropertyOfCurrentIsolate(element)) return CURRENT_ISOLATE;
     LibraryElement library = element.getLibrary();
     if (library == compiler.interceptorsLibrary) return 'J';
     if (library.isInternalLibrary) return 'H';
     if (library.isPlatformLibrary) {
       if ('${library.canonicalUri}' == 'dart:html') return 'W';
       return 'P';
     }
     return userGlobalObjects[
-        library.getLibraryOrScriptName().hashCode % userGlobalObjects.length];
+        library.getLibraryName().hashCode % userGlobalObjects.length];

[ahe, 2013/10/10 11:47:53]

I think we need to keep getLibraryOrScriptName. Otherwise, all unnamed libraries
hash to the same value.

   }
 
   jsAst.PropertyAccess elementAccess(Element element) {
     String name = getNameX(element);
     return new jsAst.PropertyAccess.field(
         new jsAst.VariableUse(globalObjectFor(element)),
         name);
   }
 
   String getLazyInitializerName(Element element) {
@@ skipping 524 matching lines @@
         if (!first) {
           sb.write('_');
         }
         sb.write('_');
         visit(link.head);
         first = true;
       }
     }
   }
 }