Issue 2629083005: Don't try to correctly notify V8 from the plugin interceptor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2629083005: Don't try to correctly notify V8 from the plugin interceptor (Closed)

Created:
3 years, 11 months ago by jochen (gone - plz use gerrit)

Modified:
3 years, 11 months ago

Reviewers:
haraken

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2924

Project:
chromium

Visibility:
Public.

Don't try to correctly notify V8 from the plugin interceptor Instead, I modified V8 to just cope with this behavior BUG=chromium:679345 TBR=haraken@chromium.org Review-Url: https://codereview.chromium.org/2625643002 Cr-Commit-Position: refs/heads/master@{#443212} (cherry picked from commit 8a4fe2fc28bb45f58445d5802057efdafbe7719b) Review-Url: https://codereview.chromium.org/2629083005 . Cr-Commit-Position: refs/branch-heads/2924@{#758} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/45f356d8a3036166754170d36019bb25ab128328

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -26 lines)			Patch
M	third_party/WebKit/LayoutTests/imported/wpt/html/dom/reflection-embedded-expected.txt	View	1 chunk	+10 lines, -10 lines	0 comments	Download
A	third_party/WebKit/LayoutTests/plugins/simple-expando.html	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp	View	1 chunk	+19 lines, -16 lines	0 comments	Download

Total messages: 2 (1 generated)

jochen (gone - plz use gerrit)

3 years, 11 months ago (2017-01-13 14:25:45 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
45f356d8a3036166754170d36019bb25ab128328.