Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issue 2625643002: Don't try to correctly notify V8 from the plugin interceptor (Closed)

Created:
3 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
3 years, 11 months ago
Reviewers:
haraken, Toon Verwaest
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't try to correctly notify V8 from the plugin interceptor Instead, I modified V8 to just cope with this behavior BUG=chromium:679345 R=haraken@chromium.org Review-Url: https://codereview.chromium.org/2625643002 Cr-Commit-Position: refs/heads/master@{#443212} Committed: https://chromium.googlesource.com/chromium/src/+/8a4fe2fc28bb45f58445d5802057efdafbe7719b

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -26 lines) Patch
M third_party/WebKit/LayoutTests/imported/wpt/html/dom/reflection-embedded-expected.txt View 1 1 chunk +10 lines, -10 lines 0 comments Download
A third_party/WebKit/LayoutTests/plugins/simple-expando.html View 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp View 1 chunk +19 lines, -16 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
jochen (gone - plz use gerrit)
3 years, 11 months ago (2017-01-10 10:33:14 UTC) #1
jochen (gone - plz use gerrit)
can run tryjobs before v8 side landed
3 years, 11 months ago (2017-01-10 10:37:23 UTC) #3
haraken
LGTM
3 years, 11 months ago (2017-01-10 10:44:23 UTC) #4
Toon Verwaest
lgtm
3 years, 11 months ago (2017-01-10 12:16:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2625643002/20001
3 years, 11 months ago (2017-01-12 09:38:52 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 12:46:47 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8a4fe2fc28bb45f58445d5802057...

Powered by Google App Engine
This is Rietveld 408576698