Ensure PreloadController is deallocated.

Ensure PreloadController is deallocated.

When the BrowserState is destroyed, the preload controller must be
notified to ensure it will be released. This prevents the preload
controller from receiving PrefChanged notifications after the browser
state has been destroyed.

BUG=677126
Review-Url: https://codereview.chromium.org/2629073003
Cr-Commit-Position: refs/heads/master@{#443311}
Committed: https://chromium.googlesource.com/chromium/src/+/bc2f42ed9c2973b356755d4c86b9b521ca66f00c

[michaeldo, 2017-01-12 18:45:49]

michaeldo@chromium.org changed reviewers:
+ rohitrao@chromium.org

[rohitrao (ping after 24h), 2017-01-12 18:49:34]

LGTM but why wasn't this crashing before?

[michaeldo, 2017-01-12 18:52:26]

On 2017/01/12 18:49:34, rohitrao wrote:
> LGTM but why wasn't this crashing before?

That's a great question. Bisecting to the exact commit seemed to come up with
something unrelated even though this is quite simple to repo. Its possible this
is due to a combination of non-modal incognito + some other change.
Unfortunately, I couldn't find what changed that prevented this from crashing
before.

[michaeldo, 2017-01-12 18:52:51]

The CQ bit was checked by michaeldo@chromium.org

[commit-bot: I haz the power, 2017-01-12 18:53:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 19:04:50]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484247171535670, "parent_rev":
"0cf2888a1c34851785f60e914278cc07229222cb", "commit_rev":
"bc2f42ed9c2973b356755d4c86b9b521ca66f00c"}

[commit-bot: I haz the power, 2017-01-12 19:05:25]

Description was changed from

==========
Ensure PreloadController is deallocated.

When the BrowserState is destroyed, the preload controller must be
notified to ensure it will be released. This prevents the preload
controller from receiving PrefChanged notifications after the browser
state has been destroyed.

BUG=677126
==========

to

==========
Ensure PreloadController is deallocated.

When the BrowserState is destroyed, the preload controller must be
notified to ensure it will be released. This prevents the preload
controller from receiving PrefChanged notifications after the browser
state has been destroyed.

BUG=677126

Review-Url: https://codereview.chromium.org/2629073003
Cr-Commit-Position: refs/heads/master@{#443311}
Committed:
https://chromium.googlesource.com/chromium/src/+/bc2f42ed9c2973b356755d4c86b9...
==========

[commit-bot: I haz the power, 2017-01-12 19:05:26]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bc2f42ed9c2973b356755d4c86b9...