ios/chrome/browser/ui/browser_view_controller.mm - Issue 2629073003: Ensure PreloadController is deallocated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/browser_view_controller.mm

Issue 2629073003: Ensure PreloadController is deallocated. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/ui/browser_view_controller.mm

diff --git a/ios/chrome/browser/ui/browser_view_controller.mm b/ios/chrome/browser/ui/browser_view_controller.mm

index 96a7e1384d5a4ca4e19d7957b06151b6aeffe29a..fb6045a547376d1c2a64e439c906c9a54b51fb8a 100644

--- a/ios/chrome/browser/ui/browser_view_controller.mm

+++ b/ios/chrome/browser/ui/browser_view_controller.mm

@@ -1675,6 +1675,8 @@ class BrowserBookmarkModelBridge : public bookmarks::BookmarkModelObserver {

BrowserListIOS::RemoveBrowser(self);

[_toolbarController browserStateDestroyed];

[_model browserStateDestroyed];

+ [_preloadController browserStateDestroyed];

+ _preloadController.reset();

// The file remover needs the browser state, so needs to be destroyed now.

_externalFileRemover.reset();

_browserState = nullptr;

« no previous file with comments | « no previous file | ios/chrome/browser/ui/preload_controller.h » ('j') | no next file with comments »