Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2629033003: Revert of [wasm][asm.js] Disable success messages for asm.js (Closed)

Created:
3 years, 11 months ago by bradn
Modified:
3 years, 11 months ago
CC:
Michael Hablich, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [wasm][asm.js] Disable success messages for asm.js (patchset #2 id:20001 of https://codereview.chromium.org/2628703003/ ) Reason for revert: Trigger flaky test. Original issue's description: > [wasm][asm.js] Disable success messages for asm.js > > These interfere with layout tests. > > BUG=v8:4203 > R=titzer@chromium.org,jochen@chromium.org > > Review-Url: https://codereview.chromium.org/2628703003 > Cr-Commit-Position: refs/heads/master@{#42241} > Committed: https://chromium.googlesource.com/v8/v8/+/9e60e7ac365d45f3211314f1ecff395f418de770 TBR=jochen@chromium.org,titzer@chromium.org,bradnelson@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4203 Review-Url: https://codereview.chromium.org/2629033003 Cr-Commit-Position: refs/heads/master@{#42254} Committed: https://chromium.googlesource.com/v8/v8/+/26b9a9ef035eeff71ed72fe6a55644305d7d7479

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -37 lines) Patch
M src/asmjs/asm-js.cc View 2 chunks +38 lines, -37 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
bradn
Created Revert of [wasm][asm.js] Disable success messages for asm.js
3 years, 11 months ago (2017-01-12 02:21:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629033003/1
3 years, 11 months ago (2017-01-12 02:21:22 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 11 months ago (2017-01-12 02:21:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629033003/1
3 years, 11 months ago (2017-01-12 02:22:31 UTC) #7
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 11 months ago (2017-01-12 02:22:35 UTC) #9
bradnelson
lgtm
3 years, 11 months ago (2017-01-12 02:22:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629033003/1
3 years, 11 months ago (2017-01-12 02:22:50 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 02:23:04 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/26b9a9ef035eeff71ed72fe6a55644305d7...

Powered by Google App Engine
This is Rietveld 408576698