Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2628703003: [wasm][asm.js] Disable success messages for asm.js (Closed)

Created:
3 years, 11 months ago by bradnelson
Modified:
3 years, 11 months ago
CC:
Michael Hablich, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm][asm.js] Disable success messages for asm.js These interfere with layout tests. BUG=v8:4203 R=titzer@chromium.org,jochen@chromium.org Review-Url: https://codereview.chromium.org/2628703003 Cr-Commit-Position: refs/heads/master@{#42241} Committed: https://chromium.googlesource.com/v8/v8/+/9e60e7ac365d45f3211314f1ecff395f418de770

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -37 lines) Patch
M src/asmjs/asm-js.cc View 1 2 chunks +36 lines, -37 lines 0 comments Download

Messages

Total messages: 23 (12 generated)
bradn
This is the other alternative. I'm fine with this, as it's more consistent with our ...
3 years, 11 months ago (2017-01-11 16:44:36 UTC) #4
jochen (gone - plz use gerrit)
lgtm
3 years, 11 months ago (2017-01-11 16:46:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628703003/1
3 years, 11 months ago (2017-01-11 16:48:41 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/builds/10885)
3 years, 11 months ago (2017-01-11 16:51:11 UTC) #10
bradn
ptal, changed round (to allow folks to pass a flag and still get instantiate timing ...
3 years, 11 months ago (2017-01-11 17:01:25 UTC) #11
jochen (gone - plz use gerrit)
still lgtm
3 years, 11 months ago (2017-01-11 17:11:51 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628703003/20001
3 years, 11 months ago (2017-01-11 17:12:14 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/v8/v8/+/9e60e7ac365d45f3211314f1ecff395f418de770
3 years, 11 months ago (2017-01-11 17:34:06 UTC) #20
Michael Achenbach
Please have a look why https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/10284 is failing, or consider revert...
3 years, 11 months ago (2017-01-11 19:48:27 UTC) #21
bradn
Investigating...
3 years, 11 months ago (2017-01-11 20:35:18 UTC) #22
bradn
3 years, 11 months ago (2017-01-12 02:21:19 UTC) #23
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2629033003/ by bradnelson@google.com.

The reason for reverting is: Trigger flaky test..

Powered by Google App Engine
This is Rietveld 408576698