|
|
Created:
3 years, 11 months ago by bradnelson Modified:
3 years, 11 months ago CC:
Michael Hablich, v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[wasm][asm.js] Disable success messages for asm.js
These interfere with layout tests.
BUG=v8:4203
R=titzer@chromium.org,jochen@chromium.org
Review-Url: https://codereview.chromium.org/2628703003
Cr-Commit-Position: refs/heads/master@{#42241}
Committed: https://chromium.googlesource.com/v8/v8/+/9e60e7ac365d45f3211314f1ecff395f418de770
Patch Set 1 #Patch Set 2 : fix #Messages
Total messages: 23 (12 generated)
The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
bradnelson@google.com changed reviewers: + bradnelson@google.com
This is the other alternative. I'm fine with this, as it's more consistent with our behavior generally (i.e. silent on success).
lgtm
The CQ bit was unchecked by bradnelson@google.com
The CQ bit was checked by bradnelson@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
ptal, changed round (to allow folks to pass a flag and still get instantiate timing (realized that was the other reason we added it).
The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
still lgtm
The CQ bit was unchecked by bradnelson@google.com
The CQ bit was checked by bradnelson@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484154723469950, "parent_rev": "57c20f0b72145c849c6880b5aa04b729f0fa55de", "commit_rev": "9e60e7ac365d45f3211314f1ecff395f418de770"}
Message was sent while issue was closed.
Description was changed from ========== [wasm][asm.js] Disable success messages for asm.js These interfere with layout tests. BUG=v8:4203 R=titzer@chromium.org,jochen@chromium.org ========== to ========== [wasm][asm.js] Disable success messages for asm.js These interfere with layout tests. BUG=v8:4203 R=titzer@chromium.org,jochen@chromium.org Review-Url: https://codereview.chromium.org/2628703003 Cr-Commit-Position: refs/heads/master@{#42241} Committed: https://chromium.googlesource.com/v8/v8/+/9e60e7ac365d45f3211314f1ecff395f418... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/v8/v8/+/9e60e7ac365d45f3211314f1ecff395f418...
Message was sent while issue was closed.
Please have a look why https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20... is failing, or consider revert...
Message was sent while issue was closed.
Investigating...
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2629033003/ by bradnelson@google.com. The reason for reverting is: Trigger flaky test.. |