Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2628993002: Revert of [Extensions] Enable sideloading prompt on mac on canary (Closed)

Created:
3 years, 11 months ago by Devlin
Modified:
3 years, 11 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Extensions] Enable sideloading prompt on mac on canary (patchset #3 id:40001 of https://codereview.chromium.org/2623033002/ ) Reason for revert: Broke official mac compile Original issue's description: > [Extensions] Enable sideloading prompt on mac on canary > > BUG=669277 > > Review-Url: https://codereview.chromium.org/2623033002 > Cr-Commit-Position: refs/heads/master@{#442983} > Committed: https://chromium.googlesource.com/chromium/src/+/e7419b3ea146e6aa9ba26ec3fae255754f47cafb TBR=lazyboy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=669277 Review-Url: https://codereview.chromium.org/2628993002 Cr-Commit-Position: refs/heads/master@{#442993} Committed: https://chromium.googlesource.com/chromium/src/+/a4bc484244add40a1859a67244622746c5629377

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -16 lines) Patch
M chrome/browser/extensions/extension_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/external_install_manager.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/external_install_manager.cc View 3 chunks +2 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Devlin
Created Revert of [Extensions] Enable sideloading prompt on mac on canary
3 years, 11 months ago (2017-01-11 21:27:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628993002/1
3 years, 11 months ago (2017-01-11 21:28:44 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 21:30:11 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a4bc484244add40a1859a6724462...

Powered by Google App Engine
This is Rietveld 408576698