[Extensions] Enable sideloading prompt on mac on canary

[Extensions] Enable sideloading prompt on mac on canary

BUG=669277
Review-Url: https://codereview.chromium.org/2623033002
Cr-Commit-Position: refs/heads/master@{#442983}
Committed: https://chromium.googlesource.com/chromium/src/+/e7419b3ea146e6aa9ba26ec3fae255754f47cafb

[Devlin, 2017-01-10 23:08:52]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 23:09:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 00:10:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 00:10:59]

Dry run: This issue passed the CQ dry run.

[Devlin, 2017-01-11 01:28:40]

rdevlin.cronin@chromium.org changed reviewers:
+ lazyboy@chromium.org

[lazyboy, 2017-01-11 01:46:40]

https://codereview.chromium.org/2623033002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/external_install_manager.cc (right):

https://codereview.chromium.org/2623033002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/external_install_manager.cc:91: return
GetCurrentChannel() < version_info::Channel::CANARY;
Did you mean <= ?

[Devlin, 2017-01-11 15:53:33]

https://codereview.chromium.org/2623033002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/external_install_manager.cc (right):

https://codereview.chromium.org/2623033002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/external_install_manager.cc:91: return
GetCurrentChannel() < version_info::Channel::CANARY;
On 2017/01/11 01:46:40, lazyboy wrote:
> Did you mean <= ?

I did, good catch!  Done.

[Devlin, 2017-01-11 15:58:20]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 15:58:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 16:38:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 16:38:53]

Dry run: This issue passed the CQ dry run.

[lazyboy, 2017-01-11 19:19:09]

lgtm

[Devlin, 2017-01-11 19:33:27]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2017-01-11 19:34:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 19:40:40]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484163207937520,
"parent_rev": "074a68c26c2ced7eef6e6a67d8f6a3bf009e1ce8", "commit_rev":
"e7419b3ea146e6aa9ba26ec3fae255754f47cafb"}

[commit-bot: I haz the power, 2017-01-11 19:41:11]

Description was changed from

==========
[Extensions] Enable sideloading prompt on mac on canary

BUG=669277
==========

to

==========
[Extensions] Enable sideloading prompt on mac on canary

BUG=669277

Review-Url: https://codereview.chromium.org/2623033002
Cr-Commit-Position: refs/heads/master@{#442983}
Committed:
https://chromium.googlesource.com/chromium/src/+/e7419b3ea146e6aa9ba26ec3fae2...
==========

[commit-bot: I haz the power, 2017-01-11 19:41:12]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e7419b3ea146e6aa9ba26ec3fae2...

[findit-for-me, 2017-01-11 21:14:23]

FYI: Findit identified this CL at revision 442983 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

[Devlin, 2017-01-11 21:27:32]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2628993002/ by rdevlin.cronin@chromium.org.

The reason for reverting is: Broke official mac compile.