Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 2628973005: [runtime] Change MessageLocation::function to SFI. (Closed)

Created:
3 years, 11 months ago by Michael Starzinger
Modified:
3 years, 11 months ago
Reviewers:
Clemens Hammacher, Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Change MessageLocation::function to SFI. This changes the {MessageLocation} structure to no longer contain a concrete {JSFunction} object but rather a {SharedFunctionInfo}. It is much easier by now to determine, and also the concrete closure is never actually being used. R=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2628973005 Cr-Commit-Position: refs/heads/master@{#42324} Committed: https://chromium.googlesource.com/v8/v8/+/4408f8f1d9a7bba8a705c9e0ae9198cb7cb32cd3

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -15 lines) Patch
M src/isolate.cc View 1 2 chunks +5 lines, -3 lines 0 comments Download
M src/messages.h View 1 1 chunk +4 lines, -3 lines 0 comments Download
M src/messages.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-internal.cc View 1 2 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
Michael Starzinger
Yang: PTAL. Clemens: FYI.
3 years, 11 months ago (2017-01-13 10:50:14 UTC) #6
Yang
On 2017/01/13 10:50:14, Michael Starzinger wrote: > Yang: PTAL. > Clemens: FYI. lgtm
3 years, 11 months ago (2017-01-13 10:52:31 UTC) #7
Clemens Hammacher
On 2017/01/13 at 10:50:14, mstarzinger wrote: > Yang: PTAL. > Clemens: FYI. fine for me, ...
3 years, 11 months ago (2017-01-13 10:54:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628973005/20001
3 years, 11 months ago (2017-01-13 12:13:18 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 12:15:03 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/4408f8f1d9a7bba8a705c9e0ae9198cb7cb...

Powered by Google App Engine
This is Rietveld 408576698