Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: src/isolate.cc

Issue 2628973005: [runtime] Change MessageLocation::function to SFI. (Closed)
Patch Set: Rebased. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/isolate.cc
diff --git a/src/isolate.cc b/src/isolate.cc
index 268c2811398c0e477884ebbcd0439830517f9f1b..752d06de3eaeeb93af5bf969eddbe1a22119b543 100644
--- a/src/isolate.cc
+++ b/src/isolate.cc
@@ -1503,7 +1503,7 @@ bool Isolate::ComputeLocation(MessageLocation* target) {
frame->Summarize(&frames);
FrameSummary& summary = frames.last();
int pos = summary.SourcePosition();
- Handle<JSFunction> fun;
+ Handle<SharedFunctionInfo> shared;
Handle<Object> script = summary.script();
if (!script->IsScript() ||
(Script::cast(*script)->source()->IsUndefined(this))) {
@@ -1515,8 +1515,10 @@ bool Isolate::ComputeLocation(MessageLocation* target) {
// incomplete (see bug v8:5007).
if (summary.IsWasmCompiled() && !FLAG_wasm_trap_if) return false;
- if (summary.IsJavaScript()) fun = summary.AsJavaScript().function();
- *target = MessageLocation(Handle<Script>::cast(script), pos, pos + 1, fun);
+ if (summary.IsJavaScript()) {
+ shared = handle(summary.AsJavaScript().function()->shared());
+ }
+ *target = MessageLocation(Handle<Script>::cast(script), pos, pos + 1, shared);
return true;
}
« no previous file with comments | « no previous file | src/messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698