Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2628963004: Merge 56: Specify a default bitrate for VEAEncoder (Closed)

Created:
3 years, 11 months ago by emircan
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews, posciak+watch_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Specify a default bitrate for VEAEncoder This CL adds a non-zero default bitrate for VEAEncoder. When given 0 bitrate, Media Foundation H264 HW encoder does not output any results. BUG=676421 TEST= Tested https://rawgit.com/Miguelao/demos/master/mediarecorder.html H264 on Mac and Win. Review-Url: https://codereview.chromium.org/2611843002 Cr-Commit-Position: refs/heads/master@{#441427} (cherry picked from commit 185c9436cfdf89c54bbfc7141bb259f709fa84f0) NOTRY=true NOPRESUBMIT=true TBR=mcasas@chromium.org Review-Url: https://codereview.chromium.org/2628963004 Cr-Commit-Position: refs/branch-heads/2924@{#746} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/e22cbf90e88a90259866b48a09f255cee687ed57

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M content/renderer/media/video_track_recorder.cc View 3 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 6 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628963004/1
3 years, 11 months ago (2017-01-12 22:09:43 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 22:12:50 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e22cbf90e88a90259866b48a09f2...

Powered by Google App Engine
This is Rietveld 408576698