Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2611843002:
Specify a default bitrate for VEAEncoder (Closed)
|
Created:
3 years, 11 months ago by emircan Modified:
3 years, 11 months ago Reviewers:
mcasas CC:
chromium-reviews, posciak+watch_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, feature-media-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSpecify a default bitrate for VEAEncoder
This CL adds a non-zero default bitrate for VEAEncoder. When given 0 bitrate,
Media Foundation H264 HW encoder does not output any results.
BUG=676421
TEST= Tested https://rawgit.com/Miguelao/demos/master/mediarecorder.html
H264 on Mac and Win.
Committed: https://crrev.com/185c9436cfdf89c54bbfc7141bb259f709fa84f0
Cr-Commit-Position: refs/heads/master@{#441427}
Patch Set 1 : mcasas@ comments. #
Messages
Total messages: 33 (26 generated)
The CQ bit was checked by emircan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== add def bitrate BUG= ========== to ========== Specify a default bitrate for VEAEncoder This CL adds a non-zero default bitrate for VEAEncoder. When given 0 bitrate, Media Foundation H264 HW encoder does not output any results. BUG=676421 TEST= Tested H264 on Mac and Win. ==========
emircan@chromium.org changed reviewers: + mcasas@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
Description was changed from ========== Specify a default bitrate for VEAEncoder This CL adds a non-zero default bitrate for VEAEncoder. When given 0 bitrate, Media Foundation H264 HW encoder does not output any results. BUG=676421 TEST= Tested H264 on Mac and Win. ========== to ========== Specify a default bitrate for VEAEncoder This CL adds a non-zero default bitrate for VEAEncoder. When given 0 bitrate, Media Foundation H264 HW encoder does not output any results. BUG=676421 TEST= Tested https://rawgit.com/Miguelao/demos/master/mediarecorder.html H264 on Mac and Win. ==========
The CQ bit was checked by emircan@chromium.org to run a CQ dry run
Patchset #1 (id:1) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
PTAL.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
very much lgtm! https://codereview.chromium.org/2611843002/diff/20001/content/renderer/media/... File content/renderer/media/video_track_recorder.cc (right): https://codereview.chromium.org/2611843002/diff/20001/content/renderer/media/... content/renderer/media/video_track_recorder.cc:58: const int kVEADefaultBitratePerPixel = 4; This number would give us for 640x480@30fps around 1.2MBps, which seems a lot, consider using e.g. 2.
The CQ bit was checked by emircan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by emircan@chromium.org to run a CQ dry run
Patchset #1 (id:20001) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:40001) has been deleted
On 2017/01/04 16:55:50, mcasas wrote: > https://codereview.chromium.org/2611843002/diff/20001/content/renderer/media/... > content/renderer/media/video_track_recorder.cc:58: const int > kVEADefaultBitratePerPixel = 4; > This number would give us for 640x480@30fps > around 1.2MBps, which seems a lot, consider > using e.g. 2. Done.
The CQ bit was unchecked by emircan@chromium.org
The CQ bit was checked by emircan@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mcasas@chromium.org Link to the patchset: https://codereview.chromium.org/2611843002/#ps60001 (title: "mcasas@ comments.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by emircan@chromium.org
The CQ bit was checked by emircan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1483555438273160,
"parent_rev": "68900d15dfeddba01d4bf97ced705353a685c6a9", "commit_rev":
"03b2d159611017128e6eec0459715e13451d427a"}
Message was sent while issue was closed.
Description was changed from ========== Specify a default bitrate for VEAEncoder This CL adds a non-zero default bitrate for VEAEncoder. When given 0 bitrate, Media Foundation H264 HW encoder does not output any results. BUG=676421 TEST= Tested https://rawgit.com/Miguelao/demos/master/mediarecorder.html H264 on Mac and Win. ========== to ========== Specify a default bitrate for VEAEncoder This CL adds a non-zero default bitrate for VEAEncoder. When given 0 bitrate, Media Foundation H264 HW encoder does not output any results. BUG=676421 TEST= Tested https://rawgit.com/Miguelao/demos/master/mediarecorder.html H264 on Mac and Win. Review-Url: https://codereview.chromium.org/2611843002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Specify a default bitrate for VEAEncoder This CL adds a non-zero default bitrate for VEAEncoder. When given 0 bitrate, Media Foundation H264 HW encoder does not output any results. BUG=676421 TEST= Tested https://rawgit.com/Miguelao/demos/master/mediarecorder.html H264 on Mac and Win. Review-Url: https://codereview.chromium.org/2611843002 ========== to ========== Specify a default bitrate for VEAEncoder This CL adds a non-zero default bitrate for VEAEncoder. When given 0 bitrate, Media Foundation H264 HW encoder does not output any results. BUG=676421 TEST= Tested https://rawgit.com/Miguelao/demos/master/mediarecorder.html H264 on Mac and Win. Committed: https://crrev.com/185c9436cfdf89c54bbfc7141bb259f709fa84f0 Cr-Commit-Position: refs/heads/master@{#441427} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/185c9436cfdf89c54bbfc7141bb259f709fa84f0 Cr-Commit-Position: refs/heads/master@{#441427} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
