Removes grab input window and extra grab and ungrab in X11WholeScreenMoveLoop

ui/views/widget/desktop_aura/x11_desktop_window_move_client.cc

Index: ui/views/widget/desktop_aura/x11_desktop_window_move_client.cc
diff --git a/ui/views/widget/desktop_aura/x11_desktop_window_move_client.cc b/ui/views/widget/desktop_aura/x11_desktop_window_move_client.cc
index 195d102a5876405308953a22545444be176d71de..13975ee4228aa10dbddec0a3c4271fbb0be05c40 100644
--- a/ui/views/widget/desktop_aura/x11_desktop_window_move_client.cc
+++ b/ui/views/widget/desktop_aura/x11_desktop_window_move_client.cc
@@ -48,8 +48,10 @@ aura::client::WindowMoveResult X11DesktopWindowMoveClient::RunMoveLoop(
     aura::client::WindowMoveSource move_source) {
   window_offset_ = drag_offset;
   host_ = source->GetHost();
+  host_->SetCapture();

[pkotwicz, 2014/05/07 02:22:24]

Did you end up figuring out why this is necessary?

[varkha, 2014/05/07 02:28:54]

No, but since this is largely a refactoring CL this code just repeats existing
flow. My guess is that something necessary happens when capture is released and
restored.

[varkha, 2014/05/07 19:54:28]

Yes, since the TabDragController releases capture just before running move loop.
I should be however setting capture to the source window and not just the host.

 
-  bool success = move_loop_.RunMoveLoop(source, host_->last_cursor());
+  bool success = move_loop_.RunMoveLoop(host_->last_cursor());
+  source->GetHost()->ReleaseCapture();

[sadrul, 2014/05/07 14:18:16]

host_->ReleaseCapture()? (or is it possible for |this| to be destroyed from the
run-loop?)

[varkha, 2014/05/07 19:54:28]

host_ gets reset in OnMoveLoopEnded() in this class, but we don't really need
this release anyway if the capture is properly set and released in
TabDragController and in this class. This makes the logic same as in
NativeWidgetAura::RunMoveLoop (i.e. setting capture just before the move loop
runs).

   return success ? aura::client::MOVE_SUCCESSFUL : aura::client::MOVE_CANCELED;
 }