Removes grab input window and extra grab and ungrab in X11WholeScreenMoveLoop

ui/views/widget/desktop_aura/x11_desktop_window_move_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/widget/desktop_aura/x11_desktop_window_move_client.h"
 
 #include <X11/Xlib.h>
 
 #include "base/debug/stack_trace.h"
 #include "base/message_loop/message_loop.h"
@@ skipping 30 matching lines @@
 
 ////////////////////////////////////////////////////////////////////////////////
 // DesktopWindowTreeHostLinux, aura::client::WindowMoveClient implementation:
 
 aura::client::WindowMoveResult X11DesktopWindowMoveClient::RunMoveLoop(
     aura::Window* source,
     const gfx::Vector2d& drag_offset,
     aura::client::WindowMoveSource move_source) {
   window_offset_ = drag_offset;
   host_ = source->GetHost();
+  host_->SetCapture();

[pkotwicz, 2014/05/07 02:22:24]

Did you end up figuring out why this is necessary?

[varkha, 2014/05/07 02:28:54]

No, but since this is largely a refactoring CL this code just repeats existing
flow. My guess is that something necessary happens when capture is released and
restored.

[varkha, 2014/05/07 19:54:28]

Yes, since the TabDragController releases capture just before running move loop.
I should be however setting capture to the source window and not just the host.

 
-  bool success = move_loop_.RunMoveLoop(source, host_->last_cursor());
+  bool success = move_loop_.RunMoveLoop(host_->last_cursor());
+  source->GetHost()->ReleaseCapture();

[sadrul, 2014/05/07 14:18:16]

host_->ReleaseCapture()? (or is it possible for |this| to be destroyed from the
run-loop?)

[varkha, 2014/05/07 19:54:28]

host_ gets reset in OnMoveLoopEnded() in this class, but we don't really need
this release anyway if the capture is properly set and released in
TabDragController and in this class. This makes the logic same as in
NativeWidgetAura::RunMoveLoop (i.e. setting capture just before the move loop
runs).

   return success ? aura::client::MOVE_SUCCESSFUL : aura::client::MOVE_CANCELED;
 }
 
 void X11DesktopWindowMoveClient::EndMoveLoop() {
   move_loop_.EndMoveLoop();
 }
 
 }  // namespace views