Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2628893003: [api] Mark functions related to object grouping as DEPRECATE_SOON (Closed)

Created:
3 years, 11 months ago by Michael Lippautz
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[api] Mark functions related to object grouping as DEPRECATE_SOON Embedders should use the EmbedderHeapTracer API. BUG=v8:5828 Review-Url: https://codereview.chromium.org/2628893003 Cr-Commit-Position: refs/heads/master@{#42269} Committed: https://chromium.googlesource.com/v8/v8/+/e00eae9e89dba96c523fec1ab5a60714ecb23567

Patch Set 1 #

Patch Set 2 : Also mark MarkIndependent #

Patch Set 3 : Fix compilation #

Patch Set 4 : Remove uses of *Independent from the API #

Patch Set 5 : More dead code #

Patch Set 6 : Even more dead code #

Patch Set 7 : Bring back some code #

Patch Set 8 : Bring back MarkIndependent #

Patch Set 9 : Remove object grouping tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -455 lines) Patch
M include/v8.h View 1 2 3 4 5 6 7 3 chunks +12 lines, -6 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 2 3 4 5 7 8 1 chunk +0 lines, -38 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -329 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 2 3 4 5 7 8 1 chunk +0 lines, -82 lines 0 comments Download

Messages

Total messages: 32 (24 generated)
Michael Lippautz
ptal We could also deprecate MarkIndependent?
3 years, 11 months ago (2017-01-11 18:46:07 UTC) #2
jochen (gone - plz use gerrit)
On 2017/01/11 at 18:46:07, mlippautz wrote: > ptal > > We could also deprecate MarkIndependent? ...
3 years, 11 months ago (2017-01-11 18:53:42 UTC) #3
Michael Lippautz
On 2017/01/11 18:53:42, jochen wrote: > On 2017/01/11 at 18:46:07, mlippautz wrote: > > ptal ...
3 years, 11 months ago (2017-01-11 19:09:06 UTC) #4
jochen (gone - plz use gerrit)
you'll need to rip out the usages from v8 already now
3 years, 11 months ago (2017-01-12 08:35:49 UTC) #13
Michael Lippautz
Independent nodes are also collected by the Scavenger. It's undocumented (but tested) behavior.
3 years, 11 months ago (2017-01-12 13:57:28 UTC) #26
jochen (gone - plz use gerrit)
lgtm
3 years, 11 months ago (2017-01-12 13:58:44 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628893003/160001
3 years, 11 months ago (2017-01-12 14:00:24 UTC) #29
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 14:02:29 UTC) #32
Message was sent while issue was closed.
Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/v8/v8/+/e00eae9e89dba96c523fec1ab5a60714ecb...

Powered by Google App Engine
This is Rietveld 408576698