Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(759)

Unified Diff: test/cctest/heap/test-heap.cc

Issue 2628893003: [api] Mark functions related to object grouping as DEPRECATE_SOON (Closed)
Patch Set: Remove object grouping tests Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/v8.h ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/heap/test-heap.cc
diff --git a/test/cctest/heap/test-heap.cc b/test/cctest/heap/test-heap.cc
index 6cad837c415656b2672507194f456465669f00b1..b044cfed009e25c3f26c3f8414bd3ceb4edde91e 100644
--- a/test/cctest/heap/test-heap.cc
+++ b/test/cctest/heap/test-heap.cc
@@ -6200,44 +6200,6 @@ TEST(SharedFunctionInfoIterator) {
CHECK_EQ(0, sfi_count);
}
-
-template <typename T>
-static UniqueId MakeUniqueId(const Persistent<T>& p) {
- return UniqueId(reinterpret_cast<uintptr_t>(*v8::Utils::OpenPersistent(p)));
-}
-
-
-TEST(Regress519319) {
- if (!FLAG_incremental_marking) return;
- CcTest::InitializeVM();
- v8::Isolate* isolate = CcTest::isolate();
- v8::HandleScope scope(isolate);
- Heap* heap = CcTest::heap();
- LocalContext context;
-
- v8::Persistent<Value> parent;
- v8::Persistent<Value> child;
-
- parent.Reset(isolate, v8::Object::New(isolate));
- child.Reset(isolate, v8::Object::New(isolate));
-
- heap::SimulateFullSpace(heap->old_space());
- CcTest::CollectGarbage(OLD_SPACE);
- {
- UniqueId id = MakeUniqueId(parent);
- isolate->SetObjectGroupId(parent, id);
- isolate->SetReferenceFromGroup(id, child);
- }
- // The CollectGarbage call above starts sweeper threads.
- // The crash will happen if the following two functions
- // are called before sweeping finishes.
- heap->StartIncrementalMarking(i::Heap::kNoGCFlags,
- i::GarbageCollectionReason::kTesting);
- heap->FinalizeIncrementalMarkingIfComplete(
- i::GarbageCollectionReason::kTesting);
-}
-
-
HEAP_TEST(Regress587004) {
FLAG_concurrent_sweeping = false;
#ifdef VERIFY_HEAP
« no previous file with comments | « include/v8.h ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698