Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Issue 2628883006: Revert of [wasm] Enforce that function bodies end with the \"end\" opcode. (Closed)

Created:
3 years, 11 months ago by Dan Ehrenberg
Modified:
3 years, 11 months ago
CC:
jbroman, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [wasm] Enforce that function bodies end with the \"end\" opcode. (patchset #3 id:40001 of https://codereview.chromium.org/2630553002/ ) Reason for revert: Caused tree to close by failing compilation: https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20clang/builds/4451 Original issue's description: > [wasm] Enforce that function bodies end with the \"end\" opcode. > > R=rossberg@chromium.org > BUG=chromium:575167 > > Review-Url: https://codereview.chromium.org/2630553002 > Cr-Commit-Position: refs/heads/master@{#42286} > Committed: https://chromium.googlesource.com/v8/v8/+/fcc6e85ec6b01e5367795f98aff104b1ff23f619 TBR=mtrofin@chromium.org,rossberg@chromium.org,jbroman@chromium.org,titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:575167 Review-Url: https://codereview.chromium.org/2628883006 Cr-Commit-Position: refs/heads/master@{#42287} Committed: https://chromium.googlesource.com/v8/v8/+/1d32a3989bc474745eeb618ebf094634f4efbb36

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -117 lines) Patch
M src/asmjs/asm-wasm-builder.cc View 3 chunks +0 lines, -6 lines 0 comments Download
M src/wasm/function-body-decoder.cc View 3 chunks +37 lines, -7 lines 0 comments Download
M src/wasm/wasm-macro-gen.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/wasm/wasm-text.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 1 chunk +3 lines, -9 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-interpreter.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/wasm/test-run-wasm-module.cc View 18 chunks +19 lines, -25 lines 0 comments Download
M test/cctest/wasm/test-wasm-breakpoints.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M test/cctest/wasm/wasm-run-utils.h View 1 chunk +1 line, -12 lines 0 comments Download
M test/debugger/debug/wasm/frame-inspection.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/inspector/debugger/wasm-scripts-expected.txt View 1 chunk +10 lines, -12 lines 0 comments Download
M test/inspector/debugger/wasm-source-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M test/inspector/debugger/wasm-stack-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/wasm/incrementer.wasm View Binary file 0 comments Download
M test/mjsunit/wasm/table.js View 3 chunks +3 lines, -3 lines 0 comments Download
M test/mjsunit/wasm/wasm-module-builder.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/unittests/value-serializer-unittest.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M test/unittests/wasm/function-body-decoder-unittest.cc View 3 chunks +12 lines, -19 lines 0 comments Download
M test/unittests/wasm/module-decoder-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/wasm/wasm-macro-gen-unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Dan Ehrenberg
Created Revert of [wasm] Enforce that function bodies end with the \"end\" opcode.
3 years, 11 months ago (2017-01-12 20:00:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628883006/1
3 years, 11 months ago (2017-01-12 20:00:54 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/1d32a3989bc474745eeb618ebf094634f4efbb36
3 years, 11 months ago (2017-01-12 20:01:12 UTC) #6
Dan Ehrenberg
3 years, 11 months ago (2017-01-12 22:27:20 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2628203003/ by littledan@chromium.org.

The reason for reverting is: Try a reland; this might not have been the source
of tree-closing..

Powered by Google App Engine
This is Rietveld 408576698