[wasm] Enforce that function bodies end with the \"end\" opcode.

[wasm] Enforce that function bodies end with the \"end\" opcode.

R=rossberg@chromium.org
BUG=chromium:575167
Review-Url: https://codereview.chromium.org/2630553002
Cr-Original-Original-Commit-Position: refs/heads/master@{#42286}
Committed: https://chromium.googlesource.com/v8/v8/+/fcc6e85ec6b01e5367795f98aff104b1ff23f619
Review-Url: https://codereview.chromium.org/2630553002
Cr-Original-Commit-Position: refs/heads/master@{#42315}
Committed: https://chromium.googlesource.com/v8/v8/+/74a2f9b7d3c3d9a9284ab8d5a9d08618b8194966
Review-Url: https://codereview.chromium.org/2630553002
Cr-Commit-Position: refs/heads/master@{#42350}
Committed: https://chromium.googlesource.com/v8/v8/+/7d42244a7ea0a807e8e4fc626b58c233c1c4f2dc

[titzer, 2017-01-12 15:21:27]

The CQ bit was checked by titzer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 15:21:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rossberg, 2017-01-12 15:40:35]

lgtm

[rossberg, 2017-01-12 15:40:47]

https://codereview.chromium.org/2630553002/diff/1/src/asmjs/asm-wasm-builder.cc
File src/asmjs/asm-wasm-builder.cc (right):

https://codereview.chromium.org/2630553002/diff/1/src/asmjs/asm-wasm-builder....
src/asmjs/asm-wasm-builder.cc:548: if (scope_ == kFuncScope) {
Stupid question: how can this be not a function scope in asm.js?

[commit-bot: I haz the power, 2017-01-12 15:46:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 15:46:07]

Dry run: Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/20633)
  v8_win64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng_triggered/b...)

[titzer, 2017-01-12 15:56:41]

The CQ bit was checked by titzer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 15:56:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 16:17:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 16:17:46]

Dry run: Try jobs failed on following builders:
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/15447)
  v8_mac_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bui...)

[titzer, 2017-01-12 17:46:03]

The CQ bit was checked by titzer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 17:46:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 18:13:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 18:13:46]

Dry run: This issue passed the CQ dry run.

[titzer, 2017-01-12 18:29:28]

On 2017/01/12 15:40:47, rossberg wrote:
>
https://codereview.chromium.org/2630553002/diff/1/src/asmjs/asm-wasm-builder.cc
> File src/asmjs/asm-wasm-builder.cc (right):
> 
>
https://codereview.chromium.org/2630553002/diff/1/src/asmjs/asm-wasm-builder....
> src/asmjs/asm-wasm-builder.cc:548: if (scope_ == kFuncScope) {
> Stupid question: how can this be not a function scope in asm.js?

As discussed in person, this is a special kind of asm.js scope.

[Mircea Trofin, 2017-01-12 19:22:01]

mtrofin@chromium.org changed reviewers:
+ mtrofin@chromium.org

[Mircea Trofin, 2017-01-12 19:22:02]

https://codereview.chromium.org/2630553002/diff/40001/test/unittests/value-se...
File test/unittests/value-serializer-unittest.cc (right):

https://codereview.chromium.org/2630553002/diff/40001/test/unittests/value-se...
test/unittests/value-serializer-unittest.cc:2442: 0,   97, 115, 109, 13, 0,  0,
0, 1,   6,   1,  96,  1,   127, 1,   127,
Should we keep this hex formatted, for consistency?

https://codereview.chromium.org/2630553002/diff/40001/test/unittests/value-se...
test/unittests/value-serializer-unittest.cc:2524: if (true) return;  //
TODO(mtrofin): fix this test
Perhaps jbroman can help.

[Mircea Trofin, 2017-01-12 19:22:30]

Description was changed from

==========
[wasm] Enforce that function bodies end with the \"end\" opcode.

R=rossberg@chromium.org
BUG=chromium:575167
==========

to

==========
[wasm] Enforce that function bodies end with the \"end\" opcode.

R=rossberg@chromium.org
BUG=chromium:575167
==========

[Mircea Trofin, 2017-01-12 19:23:59]

+jbroman - Jeremy, if you could please look at the change in
value-serializer-unittest.cc; main question is how to produce that byte array of
serialized data (so we can do the same).

Thanks!

[titzer, 2017-01-12 19:44:13]

The CQ bit was checked by titzer@chromium.org

[titzer, 2017-01-12 19:44:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
rossberg@chromium.org
Link to the patchset: https://codereview.chromium.org/2630553002/#ps40001
(title: "Update inspector tests")

[commit-bot: I haz the power, 2017-01-12 19:44:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 19:46:26]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484250253606280,
"parent_rev": "723aeeaba2d672657675306004b9e91fdc396ee6", "commit_rev":
"fcc6e85ec6b01e5367795f98aff104b1ff23f619"}

[commit-bot: I haz the power, 2017-01-12 19:46:31]

Description was changed from

==========
[wasm] Enforce that function bodies end with the \"end\" opcode.

R=rossberg@chromium.org
BUG=chromium:575167
==========

to

==========
[wasm] Enforce that function bodies end with the \"end\" opcode.

R=rossberg@chromium.org
BUG=chromium:575167

Review-Url: https://codereview.chromium.org/2630553002
Cr-Commit-Position: refs/heads/master@{#42286}
Committed:
https://chromium.googlesource.com/v8/v8/+/fcc6e85ec6b01e5367795f98aff104b1ff2...
==========

[commit-bot: I haz the power, 2017-01-12 19:46:32]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/fcc6e85ec6b01e5367795f98aff104b1ff2...

[jbroman, 2017-01-12 19:58:12]

jbroman@chromium.org changed reviewers:
+ jbroman@chromium.org

[jbroman, 2017-01-12 19:58:13]

https://codereview.chromium.org/2630553002/diff/40001/test/unittests/value-se...
File test/unittests/value-serializer-unittest.cc (right):

https://codereview.chromium.org/2630553002/diff/40001/test/unittests/value-se...
test/unittests/value-serializer-unittest.cc:2524: if (true) return;  //
TODO(mtrofin): fix this test
On 2017/01/12 at 19:22:02, Mircea Trofin wrote:
> Perhaps jbroman can help.

I generated them by running "content_shell --expose-internals-for-testing" and
then using internals.serializeObject in DevTools (and reformatting).

Be aware that whenever you do need to regenerate these, it implies that you're
making a backward-compat-breaking change.

[Dan Ehrenberg, 2017-01-12 20:00:49]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2628883006/ by littledan@chromium.org.

The reason for reverting is: Caused tree to close by failing compilation:

https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20clang/builds....

[titzer, 2017-01-13 09:53:01]

Description was changed from

==========
[wasm] Enforce that function bodies end with the \"end\" opcode.

R=rossberg@chromium.org
BUG=chromium:575167

Review-Url: https://codereview.chromium.org/2630553002
Cr-Commit-Position: refs/heads/master@{#42286}
Committed:
https://chromium.googlesource.com/v8/v8/+/fcc6e85ec6b01e5367795f98aff104b1ff2...
==========

to

==========
[wasm] Enforce that function bodies end with the \"end\" opcode.

R=rossberg@chromium.org
BUG=chromium:575167

Review-Url: https://codereview.chromium.org/2630553002
Cr-Commit-Position: refs/heads/master@{#42286}
Committed:
https://chromium.googlesource.com/v8/v8/+/fcc6e85ec6b01e5367795f98aff104b1ff2...
==========

[titzer, 2017-01-13 10:18:14]

The CQ bit was checked by titzer@chromium.org

[titzer, 2017-01-13 10:18:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
rossberg@chromium.org
Link to the patchset: https://codereview.chromium.org/2630553002/#ps100001
(title: "Extract function to prepare bytecode")

[commit-bot: I haz the power, 2017-01-13 10:18:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[titzer, 2017-01-13 10:18:49]

On 2017/01/12 20:00:49, Dan Ehrenberg wrote:
> A revert of this CL (patchset #3 id:40001) has been created in
> https://codereview.chromium.org/2628883006/ by mailto:littledan@chromium.org.
> 
> The reason for reverting is: Caused tree to close by failing compilation:
> 
>
https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20clang/builds....

Turns out this CL crashed Windows clang with an internal error. Worked around by
mutating the code a little.

[commit-bot: I haz the power, 2017-01-13 10:50:08]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1484302694947500,
"parent_rev": "52d05e12188c21ccf1a30bafb1f545945dd28c3f", "commit_rev":
"74a2f9b7d3c3d9a9284ab8d5a9d08618b8194966"}

[commit-bot: I haz the power, 2017-01-13 10:50:11]

Description was changed from

==========
[wasm] Enforce that function bodies end with the \"end\" opcode.

R=rossberg@chromium.org
BUG=chromium:575167

Review-Url: https://codereview.chromium.org/2630553002
Cr-Commit-Position: refs/heads/master@{#42286}
Committed:
https://chromium.googlesource.com/v8/v8/+/fcc6e85ec6b01e5367795f98aff104b1ff2...
==========

to

==========
[wasm] Enforce that function bodies end with the \"end\" opcode.

R=rossberg@chromium.org
BUG=chromium:575167

Review-Url: https://codereview.chromium.org/2630553002
Cr-Original-Commit-Position: refs/heads/master@{#42286}
Committed:
https://chromium.googlesource.com/v8/v8/+/fcc6e85ec6b01e5367795f98aff104b1ff2...
Review-Url: https://codereview.chromium.org/2630553002
Cr-Commit-Position: refs/heads/master@{#42315}
Committed:
https://chromium.googlesource.com/v8/v8/+/74a2f9b7d3c3d9a9284ab8d5a9d08618b81...
==========

[commit-bot: I haz the power, 2017-01-13 10:50:13]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/v8/v8/+/74a2f9b7d3c3d9a9284ab8d5a9d08618b81...

[titzer, 2017-01-13 11:32:03]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/2636463002/ by titzer@chromium.org.

The reason for reverting is: Still breaks Win64 clang build..

[titzer, 2017-01-13 17:00:22]

Description was changed from

==========
[wasm] Enforce that function bodies end with the \"end\" opcode.

R=rossberg@chromium.org
BUG=chromium:575167

Review-Url: https://codereview.chromium.org/2630553002
Cr-Original-Commit-Position: refs/heads/master@{#42286}
Committed:
https://chromium.googlesource.com/v8/v8/+/fcc6e85ec6b01e5367795f98aff104b1ff2...
Review-Url: https://codereview.chromium.org/2630553002
Cr-Commit-Position: refs/heads/master@{#42315}
Committed:
https://chromium.googlesource.com/v8/v8/+/74a2f9b7d3c3d9a9284ab8d5a9d08618b81...
==========

to

==========
[wasm] Enforce that function bodies end with the \"end\" opcode.

R=rossberg@chromium.org
BUG=chromium:575167

Review-Url: https://codereview.chromium.org/2630553002
Cr-Original-Commit-Position: refs/heads/master@{#42286}
Committed:
https://chromium.googlesource.com/v8/v8/+/fcc6e85ec6b01e5367795f98aff104b1ff2...
Review-Url: https://codereview.chromium.org/2630553002
Cr-Commit-Position: refs/heads/master@{#42315}
Committed:
https://chromium.googlesource.com/v8/v8/+/74a2f9b7d3c3d9a9284ab8d5a9d08618b81...
==========

[titzer, 2017-01-15 20:51:57]

The CQ bit was checked by titzer@chromium.org

[titzer, 2017-01-15 20:51:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
rossberg@chromium.org
Link to the patchset: https://codereview.chromium.org/2630553002/#ps120001
(title: "Collapse some tests together")

[commit-bot: I haz the power, 2017-01-15 20:52:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[titzer, 2017-01-15 20:59:46]

On 2017/01/13 11:32:03, titzer wrote:
> A revert of this CL (patchset #6 id:100001) has been created in
> https://codereview.chromium.org/2636463002/ by mailto:titzer@chromium.org.
> 
> The reason for reverting is: Still breaks Win64 clang build..

Per https://bugs.chromium.org/p/chromium/issues/detail?id=680947#c5, it seems
the problem is actually...too many tests. Dun dun dun!

[commit-bot: I haz the power, 2017-01-15 21:18:54]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1484513517025150,
"parent_rev": "ccf0998d6327db9ef48aa8ca0531bf25b9cb13c8", "commit_rev":
"7d42244a7ea0a807e8e4fc626b58c233c1c4f2dc"}

[commit-bot: I haz the power, 2017-01-15 21:18:59]

Description was changed from

==========
[wasm] Enforce that function bodies end with the \"end\" opcode.

R=rossberg@chromium.org
BUG=chromium:575167

Review-Url: https://codereview.chromium.org/2630553002
Cr-Original-Commit-Position: refs/heads/master@{#42286}
Committed:
https://chromium.googlesource.com/v8/v8/+/fcc6e85ec6b01e5367795f98aff104b1ff2...
Review-Url: https://codereview.chromium.org/2630553002
Cr-Commit-Position: refs/heads/master@{#42315}
Committed:
https://chromium.googlesource.com/v8/v8/+/74a2f9b7d3c3d9a9284ab8d5a9d08618b81...
==========

to

==========
[wasm] Enforce that function bodies end with the \"end\" opcode.

R=rossberg@chromium.org
BUG=chromium:575167

Review-Url: https://codereview.chromium.org/2630553002
Cr-Original-Original-Commit-Position: refs/heads/master@{#42286}
Committed:
https://chromium.googlesource.com/v8/v8/+/fcc6e85ec6b01e5367795f98aff104b1ff2...
Review-Url: https://codereview.chromium.org/2630553002
Cr-Original-Commit-Position: refs/heads/master@{#42315}
Committed:
https://chromium.googlesource.com/v8/v8/+/74a2f9b7d3c3d9a9284ab8d5a9d08618b81...
Review-Url: https://codereview.chromium.org/2630553002
Cr-Commit-Position: refs/heads/master@{#42350}
Committed:
https://chromium.googlesource.com/v8/v8/+/7d42244a7ea0a807e8e4fc626b58c233c1c...
==========

[commit-bot: I haz the power, 2017-01-15 21:19:00]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/v8/v8/+/7d42244a7ea0a807e8e4fc626b58c233c1c...