Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issue 2628773002: Replaced RefPtr::release with std::move in Source/platform. (Closed)

Created:
3 years, 11 months ago by Bugs Nash
Modified:
3 years, 11 months ago
Reviewers:
haraken, Yuta Kitamura
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replaced RefPtr::release with std::move in Source/platform. Part of the removal of PassRefPtr. Replaces many of the calls to RefPtr::release with a std::move wrap, which returns a RefPtr instead of a PassRefPtr. As the code currently stands, most methods still expect a PassRefPtr and so the PassRefPtr initialising constructor will be called passing in the RefPtr rvalue, which calls RefPtr::release anyway. Future patches will see these variables changed from PassRefPtr to RefPtr type then RefPtr::release will not be used at all. Does not handle RefPtr::release of non member variables in return statements as these cases sometimes default to move (in the case of returning a local variable). These will be handled in future patches. BUG=494719 Review-Url: https://codereview.chromium.org/2628773002 Cr-Commit-Position: refs/heads/master@{#443416} Committed: https://chromium.googlesource.com/chromium/src/+/3ec92ab7b54be886a9b6849c0c6d1ddda99439ee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M third_party/WebKit/Source/platform/blob/BlobData.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebURLResponse.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontFamily.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageSource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/PictureSnapshot.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
Bugs Nash
3 years, 11 months ago (2017-01-11 05:04:10 UTC) #3
haraken
LGTM
3 years, 11 months ago (2017-01-11 05:14:28 UTC) #6
Yuta Kitamura
lgtm
3 years, 11 months ago (2017-01-12 10:26:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628773002/1
3 years, 11 months ago (2017-01-12 20:54:34 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 00:44:49 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3ec92ab7b54be886a9b6849c0c6d...

Powered by Google App Engine
This is Rietveld 408576698