third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp - Issue 2628773002: Replaced RefPtr::release with std::move in Source/platform.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp

Issue 2628773002: Replaced RefPtr::release with std::move in Source/platform. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaper.cpp ('k') | third_party/WebKit/Source/platform/graphics/ImageSource.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp b/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp

index cc9d27d796482b121ec230af57446b5fc02b0575..f242a1d11733dbba50aefe10c742a6c6ea13acce 100644

--- a/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp

+++ b/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp

@@ -74,7 +74,7 @@ std::unique_ptr<DeferredImageDecoder> DeferredImageDecoder::create(

// Since we've just instantiated a fresh decoder, there's no need to reset its

// data.

- decoder->setDataInternal(data.release(), dataComplete, false);

+ decoder->setDataInternal(std::move(data), dataComplete, false);

return decoder;

}

@@ -329,8 +329,8 @@ sk_sp<SkImage> DeferredImageDecoder::createFrameImageAtIndex(

m_colorSpaceForSkImages);

DecodingImageGenerator* generator = new DecodingImageGenerator(

- m_frameGenerator, info, segmentReader.release(), m_allDataReceived, index,

- m_frameData[index].m_uniqueID);

+ m_frameGenerator, info, std::move(segmentReader), m_allDataReceived,

+ index, m_frameData[index].m_uniqueID);

sk_sp<SkImage> image = SkImage::MakeFromGenerator(

generator); // SkImage takes ownership of the generator.

if (!image)