[Devtools] Move initiator data into NetworkLog from NetworkRequest

[Devtools] Move initiator data into NetworkLog from NetworkRequest

This patch moves request initiator info into NetworkLog.

R=dgozman
BUG=668032
Review-Url: https://codereview.chromium.org/2628693002
Cr-Commit-Position: refs/heads/master@{#444606}
Committed: https://chromium.googlesource.com/chromium/src/+/cf6bde6fff78674429a4543d4aac2d536c1661ea

[allada, 2017-01-11 01:46:37]

The CQ bit was checked by allada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 01:47:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[allada, 2017-01-11 01:48:34]

PTL

[commit-bot: I haz the power, 2017-01-11 04:37:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 04:37:54]

Dry run: This issue passed the CQ dry run.

[dgozman, 2017-01-13 00:51:55]

https://codereview.chromium.org/2628693002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js (right):

https://codereview.chromium.org/2628693002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js:94: return
request[SDK.NetworkLog._networkLogForRequestSymbol] || null;
You can still do NetworkLog.FromTarget(request.target())

https://codereview.chromium.org/2628693002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js:250:
request.addEventListener(
Remove this listener somewhere?

https://codereview.chromium.org/2628693002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js:251:
SDK.NetworkRequest.Events.RedirectSourceChanged, () => delete
request[SDK.NetworkLog._initiatorInfoSymbol]);
nit: let's wrap the body in {}

[caseq, 2017-01-13 01:16:59]

caseq@chromium.org changed reviewers:
+ caseq@chromium.org

[caseq, 2017-01-13 01:16:59]

https://codereview.chromium.org/2628693002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js (right):

https://codereview.chromium.org/2628693002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js:302:
SDK.NetworkLog._initiatorChainSymbol = Symbol('InitiatorChain');
Why not merge all initiator-related info for a request into a single structure
and use just one symbol?

[allada, 2017-01-17 22:10:15]

Patchset #2 (id:20001) has been deleted

[allada, 2017-01-17 22:10:30]

allada@chromium.org changed reviewers:
+ luoe@chromium.org

[allada, 2017-01-17 22:10:31]

PTaL

https://codereview.chromium.org/2628693002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js (right):

https://codereview.chromium.org/2628693002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js:94: return
request[SDK.NetworkLog._networkLogForRequestSymbol] || null;
On 2017/01/13 00:51:54, dgozman wrote:
> You can still do NetworkLog.FromTarget(request.target())

Done.

https://codereview.chromium.org/2628693002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js:250:
request.addEventListener(
On 2017/01/13 00:51:54, dgozman wrote:
> Remove this listener somewhere?

Done.

https://codereview.chromium.org/2628693002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js:251:
SDK.NetworkRequest.Events.RedirectSourceChanged, () => delete
request[SDK.NetworkLog._initiatorInfoSymbol]);
On 2017/01/13 00:51:54, dgozman wrote:
> nit: let's wrap the body in {}

Done.

https://codereview.chromium.org/2628693002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js:302:
SDK.NetworkLog._initiatorChainSymbol = Symbol('InitiatorChain');
On 2017/01/13 01:16:59, caseq wrote:
> Why not merge all initiator-related info for a request into a single structure
> and use just one symbol?

Done.

[dgozman, 2017-01-18 18:02:01]

lgtm

https://codereview.chromium.org/2628693002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
(right):

https://codereview.chromium.org/2628693002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js:415:
var initiatorGraph =
Components.NetworkRequest.initiatorGraphForRequest(this._request);
SDK? NetworkLog?

https://codereview.chromium.org/2628693002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js (right):

https://codereview.chromium.org/2628693002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js:94: static
networkLogForRequest(request) {
fromRequest

https://codereview.chromium.org/2628693002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js:103: /** @type
{!{info: ?SDK.NetworkLog._InitiatorInfo, chain: !Set<!SDK.NetworkRequest>,
request: (?SDK.NetworkRequest|undefined)}} */
Why do you have to type? It doesn't help later anyway.

[allada, 2017-01-19 00:50:11]

done.

https://codereview.chromium.org/2628693002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
(right):

https://codereview.chromium.org/2628693002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js:415:
var initiatorGraph =
Components.NetworkRequest.initiatorGraphForRequest(this._request);
On 2017/01/18 18:02:00, dgozman wrote:
> SDK? NetworkLog?

Done.

https://codereview.chromium.org/2628693002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js (right):

https://codereview.chromium.org/2628693002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js:94: static
networkLogForRequest(request) {
On 2017/01/18 18:02:01, dgozman wrote:
> fromRequest

Done.

https://codereview.chromium.org/2628693002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js:103: /** @type
{!{info: ?SDK.NetworkLog._InitiatorInfo, chain: !Set<!SDK.NetworkRequest>,
request: (?SDK.NetworkRequest|undefined)}} */
On 2017/01/18 18:02:01, dgozman wrote:
> Why do you have to type? It doesn't help later anyway.

I typed it so that future people looking at the code can understand what this
symbol consists of (this isn't for closure, it's for us).

[allada, 2017-01-19 00:50:18]

The CQ bit was checked by allada@chromium.org

[allada, 2017-01-19 00:50:21]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2628693002/#ps100001
(title: "changes")

[commit-bot: I haz the power, 2017-01-19 00:50:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 02:47:43]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1484787018055140,
"parent_rev": "cc88b786390a51a344f4265503fe64a3db8e6968", "commit_rev":
"cf6bde6fff78674429a4543d4aac2d536c1661ea"}

[commit-bot: I haz the power, 2017-01-19 02:48:15]

Description was changed from

==========
[Devtools] Move initiator data into NetworkLog from NetworkRequest

This patch moves request initiator info into NetworkLog.

R=dgozman
BUG=668032
==========

to

==========
[Devtools] Move initiator data into NetworkLog from NetworkRequest

This patch moves request initiator info into NetworkLog.

R=dgozman
BUG=668032

Review-Url: https://codereview.chromium.org/2628693002
Cr-Commit-Position: refs/heads/master@{#444606}
Committed:
https://chromium.googlesource.com/chromium/src/+/cf6bde6fff78674429a4543d4aac...
==========

[commit-bot: I haz the power, 2017-01-19 02:48:20]

Committed patchset #5 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/cf6bde6fff78674429a4543d4aac...