Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

Issue 2628693002: [Devtools] Move initiator data into NetworkLog from NetworkRequest (Closed)
Patch Set: changes Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
index beb60625a5d81e83ed75ed71e3bcd4fd35c04e36..6bed81d0c3b1994e921d2bc56ddb7b8aaa839de8 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
@@ -240,8 +240,8 @@ Network.NetworkRequestNode = class extends Network.NetworkNode {
var bRequest = b.request();
if (!aRequest || !bRequest)
return !aRequest ? -1 : 1;
- var aInitiator = aRequest.initiatorInfo();
- var bInitiator = bRequest.initiatorInfo();
+ var aInitiator = SDK.NetworkLog.initiatorInfoForRequest(aRequest);
+ var bInitiator = SDK.NetworkLog.initiatorInfoForRequest(bRequest);
if (aInitiator.type < bInitiator.type)
return -1;
@@ -412,7 +412,7 @@ Network.NetworkRequestNode = class extends Network.NetworkNode {
showingInitiatorChainChanged() {
var showInitiatorChain = this.showingInitiatorChain();
- var initiatorGraph = this._request.initiatorGraph();
+ var initiatorGraph = SDK.NetworkLog.initiatorGraphForRequest(this._request);
for (var request of initiatorGraph.initiators) {
if (request === this._request)
continue;
@@ -618,7 +618,8 @@ Network.NetworkRequestNode = class extends Network.NetworkNode {
* @protected
*/
willAttach() {
- if (this._initiatorCell && this._request.initiatorInfo().type === SDK.NetworkRequest.InitiatorType.Script)
+ if (this._initiatorCell &&
+ SDK.NetworkLog.initiatorInfoForRequest(this._request).type === SDK.NetworkRequest.InitiatorType.Script)
this._initiatorCell.insertBefore(this._linkifiedInitiatorAnchor, this._initiatorCell.firstChild);
}
@@ -750,7 +751,7 @@ Network.NetworkRequestNode = class extends Network.NetworkNode {
_renderInitiatorCell(cell) {
this._initiatorCell = cell;
var request = this._request;
- var initiator = request.initiatorInfo();
+ var initiator = SDK.NetworkLog.initiatorInfoForRequest(request);
if (request.timing && request.timing.pushStart)
cell.appendChild(createTextNode(Common.UIString('Push / ')));

Powered by Google App Engine
This is Rietveld 408576698