content/browser/service_worker/service_worker_version.h - Issue 2628553002: ServiceWorker: OnSimpleEventFinished could be called after timed out

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_version.h

Issue 2628553002: ServiceWorker: OnSimpleEventFinished could be called after timed out (Closed)

Patch Set: Fix comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/service_worker/service_worker_version.h

diff --git a/content/browser/service_worker/service_worker_version.h b/content/browser/service_worker/service_worker_version.h

index 0e26f6898754938c8ce72c82a9e0f463846fe352..57ac26103f94e93dbb8a8c7dc900aa3961bce276 100644

--- a/content/browser/service_worker/service_worker_version.h

+++ b/content/browser/service_worker/service_worker_version.h

@@ -449,7 +449,7 @@ class CONTENT_EXPORT ServiceWorkerVersion

FRIEND_TEST_ALL_PREFIXES(ServiceWorkerVersionTest, StaleUpdate_RunningWorker);

FRIEND_TEST_ALL_PREFIXES(ServiceWorkerVersionTest,

StaleUpdate_DoNotDeferTimer);

- FRIEND_TEST_ALL_PREFIXES(ServiceWorkerVersionTest, RequestTimeout);

+ FRIEND_TEST_ALL_PREFIXES(ServiceWorkerRequestTimeoutTest, RequestTimeout);

FRIEND_TEST_ALL_PREFIXES(ServiceWorkerFailToStartTest, Timeout);

FRIEND_TEST_ALL_PREFIXES(ServiceWorkerVersionBrowserTest,

TimeoutStartingWorker);