Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Unified Diff: content/browser/service_worker/service_worker_version.cc

Issue 2628553002: ServiceWorker: OnSimpleEventFinished could be called after timed out (Closed)
Patch Set: Fix comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_version.cc
diff --git a/content/browser/service_worker/service_worker_version.cc b/content/browser/service_worker/service_worker_version.cc
index 21c34b4aa38fc9cf4919c2ee1e87b61505183a57..17e10e5f4761954d8b035d4e0980042d2fbda53d 100644
--- a/content/browser/service_worker/service_worker_version.cc
+++ b/content/browser/service_worker/service_worker_version.cc
@@ -1111,9 +1111,11 @@ void ServiceWorkerVersion::OnSimpleEventFinished(
int request_id,
ServiceWorkerStatusCode status,
base::Time dispatch_event_time) {
- // Copy error callback before calling FinishRequest.
PendingRequest* request = pending_requests_.Lookup(request_id);
- DCHECK(request) << "Invalid request id";
+ // |request| will be null when the request has been timed out.
+ if (!request)
+ return;
+ // Copy error callback before calling FinishRequest.
StatusCallback callback = request->error_callback;
FinishRequest(request_id, status == SERVICE_WORKER_OK, dispatch_event_time);

Powered by Google App Engine
This is Rietveld 408576698