Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Side by Side Diff: content/browser/service_worker/service_worker_version.h

Issue 2628553002: ServiceWorker: OnSimpleEventFinished could be called after timed out (Closed)
Patch Set: Fix comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_VERSION_H_ 5 #ifndef CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_VERSION_H_
6 #define CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_VERSION_H_ 6 #define CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_VERSION_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <functional> 10 #include <functional>
(...skipping 431 matching lines...) Expand 10 before | Expand all | Expand 10 after
442 FallbackWithNoFetchHandler); 442 FallbackWithNoFetchHandler);
443 FRIEND_TEST_ALL_PREFIXES(ServiceWorkerVersionTest, IdleTimeout); 443 FRIEND_TEST_ALL_PREFIXES(ServiceWorkerVersionTest, IdleTimeout);
444 FRIEND_TEST_ALL_PREFIXES(ServiceWorkerVersionTest, SetDevToolsAttached); 444 FRIEND_TEST_ALL_PREFIXES(ServiceWorkerVersionTest, SetDevToolsAttached);
445 FRIEND_TEST_ALL_PREFIXES(ServiceWorkerVersionTest, StaleUpdate_FreshWorker); 445 FRIEND_TEST_ALL_PREFIXES(ServiceWorkerVersionTest, StaleUpdate_FreshWorker);
446 FRIEND_TEST_ALL_PREFIXES(ServiceWorkerVersionTest, 446 FRIEND_TEST_ALL_PREFIXES(ServiceWorkerVersionTest,
447 StaleUpdate_NonActiveWorker); 447 StaleUpdate_NonActiveWorker);
448 FRIEND_TEST_ALL_PREFIXES(ServiceWorkerVersionTest, StaleUpdate_StartWorker); 448 FRIEND_TEST_ALL_PREFIXES(ServiceWorkerVersionTest, StaleUpdate_StartWorker);
449 FRIEND_TEST_ALL_PREFIXES(ServiceWorkerVersionTest, StaleUpdate_RunningWorker); 449 FRIEND_TEST_ALL_PREFIXES(ServiceWorkerVersionTest, StaleUpdate_RunningWorker);
450 FRIEND_TEST_ALL_PREFIXES(ServiceWorkerVersionTest, 450 FRIEND_TEST_ALL_PREFIXES(ServiceWorkerVersionTest,
451 StaleUpdate_DoNotDeferTimer); 451 StaleUpdate_DoNotDeferTimer);
452 FRIEND_TEST_ALL_PREFIXES(ServiceWorkerVersionTest, RequestTimeout); 452 FRIEND_TEST_ALL_PREFIXES(ServiceWorkerRequestTimeoutTest, RequestTimeout);
453 FRIEND_TEST_ALL_PREFIXES(ServiceWorkerFailToStartTest, Timeout); 453 FRIEND_TEST_ALL_PREFIXES(ServiceWorkerFailToStartTest, Timeout);
454 FRIEND_TEST_ALL_PREFIXES(ServiceWorkerVersionBrowserTest, 454 FRIEND_TEST_ALL_PREFIXES(ServiceWorkerVersionBrowserTest,
455 TimeoutStartingWorker); 455 TimeoutStartingWorker);
456 FRIEND_TEST_ALL_PREFIXES(ServiceWorkerVersionBrowserTest, 456 FRIEND_TEST_ALL_PREFIXES(ServiceWorkerVersionBrowserTest,
457 TimeoutWorkerInEvent); 457 TimeoutWorkerInEvent);
458 FRIEND_TEST_ALL_PREFIXES(ServiceWorkerStallInStoppingTest, DetachThenStart); 458 FRIEND_TEST_ALL_PREFIXES(ServiceWorkerStallInStoppingTest, DetachThenStart);
459 FRIEND_TEST_ALL_PREFIXES(ServiceWorkerStallInStoppingTest, DetachThenRestart); 459 FRIEND_TEST_ALL_PREFIXES(ServiceWorkerStallInStoppingTest, DetachThenRestart);
460 FRIEND_TEST_ALL_PREFIXES(ServiceWorkerVersionTest, 460 FRIEND_TEST_ALL_PREFIXES(ServiceWorkerVersionTest,
461 RegisterForeignFetchScopes); 461 RegisterForeignFetchScopes);
462 FRIEND_TEST_ALL_PREFIXES(ServiceWorkerVersionTest, RequestNowTimeout); 462 FRIEND_TEST_ALL_PREFIXES(ServiceWorkerVersionTest, RequestNowTimeout);
(...skipping 394 matching lines...) Expand 10 before | Expand all | Expand 10 after
857 857
858 // At this point |this| can have been deleted, so don't do anything other 858 // At this point |this| can have been deleted, so don't do anything other
859 // than returning. 859 // than returning.
860 860
861 return true; 861 return true;
862 } 862 }
863 863
864 } // namespace content 864 } // namespace content
865 865
866 #endif // CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_VERSION_H_ 866 #endif // CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_VERSION_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698