JoinForTesting() in ScopedAsyncTaskScheduler.

JoinForTesting() in ScopedAsyncTaskScheduler.

TaskSchedulerImpl can't be destroyed without being joined first.

BUG=553459
Review-Url: https://codereview.chromium.org/2628533003
Cr-Commit-Position: refs/heads/master@{#442653}
Committed: https://chromium.googlesource.com/chromium/src/+/9d7cdc956eb1b63c63f6b0b2ce243eee8db5264f

[fdoray, 2017-01-10 15:12:33]

fdoray@chromium.org changed reviewers:
+ gab@chromium.org

[fdoray, 2017-01-10 15:12:34]

PTAL

[fdoray, 2017-01-10 15:33:51]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 15:34:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 16:36:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 16:36:01]

Dry run: This issue passed the CQ dry run.

[gab, 2017-01-10 18:54:12]

Since this is after Shutdown(), this will only affect CONTINUE_ON_SHUTDOWN tasks
right? These shouldn't matter though. So what is this trying to fix? Is it just
about making sure a broken CONTINUE_ON_SHUTDOWN task doesn't affect another
unrelated test?

[fdoray, 2017-01-10 19:01:50]

On 2017/01/10 18:54:12, gab wrote:
> Since this is after Shutdown(), this will only affect CONTINUE_ON_SHUTDOWN
tasks
> right? These shouldn't matter though. So what is this trying to fix? Is it
just
> about making sure a broken CONTINUE_ON_SHUTDOWN task doesn't affect another
> unrelated test?

ScopedAsyncTaskScheduler is presently unusable because ~TaskSchedulerImpl
DCHECKs that JoinForTesting() has been called. This DCHECK prevents
TaskSchedulerImpl from being destroyed inadvertently in production code (you
either get a DCHECK that JoinForTesting() hasn't been called or a presubmit
check that you call a JoinForTesting() method from non-test code).

No new tasks can be scheduled after Shutdown(). JoinForTesting() simply joins
TaskScheduler threads (implies that it waits for CONTINUE_ON_SHUTDOWN tasks that
were already running).

[gab, 2017-01-10 19:15:42]

On 2017/01/10 19:01:50, fdoray wrote:
> On 2017/01/10 18:54:12, gab wrote:
> > Since this is after Shutdown(), this will only affect CONTINUE_ON_SHUTDOWN
> tasks
> > right? These shouldn't matter though. So what is this trying to fix? Is it
> just
> > about making sure a broken CONTINUE_ON_SHUTDOWN task doesn't affect another
> > unrelated test?
> 
> ScopedAsyncTaskScheduler is presently unusable because ~TaskSchedulerImpl
> DCHECKs that JoinForTesting() has been called. This DCHECK prevents
> TaskSchedulerImpl from being destroyed inadvertently in production code (you
> either get a DCHECK that JoinForTesting() hasn't been called or a presubmit
> check that you call a JoinForTesting() method from non-test code).
> 
> No new tasks can be scheduled after Shutdown(). JoinForTesting() simply joins
> TaskScheduler threads (implies that it waits for CONTINUE_ON_SHUTDOWN tasks
that
> were already running).

okay lgtm

[fdoray, 2017-01-10 19:16:18]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2017-01-10 19:16:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 19:21:25]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484075778275670,
"parent_rev": "e947a35bcd6dce91dc4651680c48f8b996f7ea5e", "commit_rev":
"9d7cdc956eb1b63c63f6b0b2ce243eee8db5264f"}

[commit-bot: I haz the power, 2017-01-10 19:21:54]

Description was changed from

==========
JoinForTesting() in ScopedAsyncTaskScheduler.

TaskSchedulerImpl can't be destroyed without being joined first.

BUG=553459
==========

to

==========
JoinForTesting() in ScopedAsyncTaskScheduler.

TaskSchedulerImpl can't be destroyed without being joined first.

BUG=553459

Review-Url: https://codereview.chromium.org/2628533003
Cr-Commit-Position: refs/heads/master@{#442653}
Committed:
https://chromium.googlesource.com/chromium/src/+/9d7cdc956eb1b63c63f6b0b2ce24...
==========

[commit-bot: I haz the power, 2017-01-10 19:21:55]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9d7cdc956eb1b63c63f6b0b2ce24...