Use TaskScheduler instead of WorkerPool in file_ios.cc.

Use TaskScheduler instead of WorkerPool in file_ios.cc.

The following traits are used:

Priority: Inherited (default)
  The priority is inherited from the calling context (i.e. TaskTraits
  are initialized with the priority of the current task).

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

  Note: Tasks that were previously posted to base::WorkerPool should
  use this shutdown behavior because this is how base::WorkerPool
  handles all its tasks.

May Block:
  Tasks posted with MayBlock() may block. This includes but is not
  limited to tasks that wait on synchronous file I/O operations:
  read or write a file from disk, interact with a pipe or a socket,
  rename or delete a file, enumerate files in a directory, etc. This
  trait isn't required for the mere use of locks.

BUG=659191
Review-Url: https://codereview.chromium.org/2608093002
Cr-Commit-Position: refs/heads/master@{#442971}
Committed: https://chromium.googlesource.com/chromium/src/+/34db9f35de6a4531e82d3bf068f0529ca94b348b

[fdoray, 2017-01-01 23:09:58]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-01 23:10:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-01 23:16:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-01 23:16:19]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[fdoray, 2017-01-04 16:58:35]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 16:58:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 17:39:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 17:39:04]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[fdoray, 2017-01-04 19:16:00]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 19:16:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 20:15:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 20:15:04]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[fdoray, 2017-01-10 19:56:55]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 19:57:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 21:17:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 21:17:08]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[fdoray, 2017-01-11 14:35:49]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 14:36:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2017-01-11 14:37:16]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[fdoray, 2017-01-11 14:37:29]

fdoray@chromium.org changed reviewers:
+ gavinp@chromium.org

[fdoray, 2017-01-11 14:37:30]

PTAL

[commit-bot: I haz the power, 2017-01-11 14:37:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 15:50:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 15:50:30]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[gavinp, 2017-01-11 18:34:43]

lgtm

[fdoray, 2017-01-11 18:35:01]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2017-01-11 18:35:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 19:03:49]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1484159701680590,
"parent_rev": "4702f8e80cde7762dc897963ab69080e38093b97", "commit_rev":
"34db9f35de6a4531e82d3bf068f0529ca94b348b"}

[commit-bot: I haz the power, 2017-01-11 19:04:19]

Description was changed from

==========
Use TaskScheduler instead of WorkerPool in file_ios.cc.

The following traits are used:

Priority: Inherited (default)
  The priority is inherited from the calling context (i.e. TaskTraits
  are initialized with the priority of the current task).

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

  Note: Tasks that were previously posted to base::WorkerPool should
  use this shutdown behavior because this is how base::WorkerPool
  handles all its tasks.

May Block:
  Tasks posted with MayBlock() may block. This includes but is not
  limited to tasks that wait on synchronous file I/O operations:
  read or write a file from disk, interact with a pipe or a socket,
  rename or delete a file, enumerate files in a directory, etc. This
  trait isn't required for the mere use of locks.

BUG=659191
==========

to

==========
Use TaskScheduler instead of WorkerPool in file_ios.cc.

The following traits are used:

Priority: Inherited (default)
  The priority is inherited from the calling context (i.e. TaskTraits
  are initialized with the priority of the current task).

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

  Note: Tasks that were previously posted to base::WorkerPool should
  use this shutdown behavior because this is how base::WorkerPool
  handles all its tasks.

May Block:
  Tasks posted with MayBlock() may block. This includes but is not
  limited to tasks that wait on synchronous file I/O operations:
  read or write a file from disk, interact with a pipe or a socket,
  rename or delete a file, enumerate files in a directory, etc. This
  trait isn't required for the mere use of locks.

BUG=659191

Review-Url: https://codereview.chromium.org/2608093002
Cr-Commit-Position: refs/heads/master@{#442971}
Committed:
https://chromium.googlesource.com/chromium/src/+/34db9f35de6a4531e82d3bf068f0...
==========

[commit-bot: I haz the power, 2017-01-11 19:04:20]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/34db9f35de6a4531e82d3bf068f0...

[krasin1, 2017-01-11 22:28:27]

On 2017/01/11 19:04:20, commit-bot: I haz the power wrote:
> Committed patchset #6 (id:100001) as
>
https://chromium.googlesource.com/chromium/src/+/34db9f35de6a4531e82d3bf068f0...

FYI: this CL made net_unittests to fail under Control Flow Integrity:
https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux%20ToT/builds/5...

It seems that a virtual call on a null pointer is happening somewhere.

See https://www.chromium.org/developers/testing/control-flow-integrity for more
details.

[krasin1, 2017-01-12 00:08:41]

Sadly, I am failing to reproduce the issue locally. Let's wait for more bots
failures. Since it was a Clang ToT bot failing, there's a non zero chance that
the issue was on the LLVM side, not on Chromium side.

[mef, 2017-01-17 19:31:14]

On 2017/01/12 00:08:41, krasin1 wrote:
> Sadly, I am failing to reproduce the issue locally. Let's wait for more bots
> failures. Since it was a Clang ToT bot failing, there's a non zero chance that
> the issue was on the LLVM side, not on Chromium side.

This also makes Cronet_tests for iOS failing, but we don't have any testbots on
CQ or even separate waterfall for that yet.
There is potential fix for Cronet tests from lilyhoughton@ here:
https://codereview.chromium.org/2639673002/
Could you take a look to see if it makes sense?