Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1349)

Issue 2628433002: Fix flaky ShelfAppBrowserTest.MultiDisplayBasicDragAndDrop (Closed)

Created:
3 years, 11 months ago by msw
Modified:
3 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix flaky ShelfAppBrowserTest.MultiDisplayBasicDragAndDrop Use DisplayManagerTestApi::UpdateDisplay to config multi-display. (do not use the 'ash-host-window-bounds' command line flag). TODO: Figure out why this change fixes the flake ¯\_(ツ)_/¯ BUG=678622 TEST=Automated test passes consistently. R=sky@chromium.org Review-Url: https://codereview.chromium.org/2628433002 Cr-Commit-Position: refs/heads/master@{#442403} Committed: https://chromium.googlesource.com/chromium/src/+/722a6795c0472558994b50ec6669284eaf0e57ee

Patch Set 1 #

Patch Set 2 : Fix flaky ShelfAppBrowserTest.MultiDisplayBasicDragAndDrop #

Patch Set 3 : Reduce diff; just fix display config. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -22 lines) Patch
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc View 1 2 2 chunks +7 lines, -22 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
msw
Hey Scott, please take a look; thanks!
3 years, 11 months ago (2017-01-09 21:51:07 UTC) #6
sky
LGTM
3 years, 11 months ago (2017-01-09 22:51:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628433002/30001
3 years, 11 months ago (2017-01-09 23:19:26 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 23:38:08 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:30001) as
https://chromium.googlesource.com/chromium/src/+/722a6795c0472558994b50ec6669...

Powered by Google App Engine
This is Rietveld 408576698