Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc

Issue 2628433002: Fix flaky ShelfAppBrowserTest.MultiDisplayBasicDragAndDrop (Closed)
Patch Set: Reduce diff; just fix display config. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc
diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc
index 5e1d861052c2b0ad9342473e8677a4f98c4a1c31..5a94a9c1760ce75ce54a074ee9c55e55d47eb2eb 100644
--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc
+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc
@@ -76,6 +76,7 @@
#include "ui/aura/client/aura_constants.h"
#include "ui/aura/window.h"
#include "ui/base/window_open_disposition.h"
+#include "ui/display/test/display_manager_test_api.h"
#include "ui/events/event.h"
#include "ui/events/event_constants.h"
#include "ui/events/test/event_generator.h"
@@ -1890,30 +1891,14 @@ IN_PROC_BROWSER_TEST_F(ShelfAppBrowserTest, DISABLED_DragAndDrop) {
generator.ReleaseLeftButton();
}
-// Used to test drag & drop an item between app list and shelf with multi
-// display environment.
-class ShelfAppBrowserTestWithMultiMonitor
- : public ShelfAppBrowserTestNoDefaultBrowser {
- protected:
- ShelfAppBrowserTestWithMultiMonitor() {}
- ~ShelfAppBrowserTestWithMultiMonitor() override {}
-
- void SetUpCommandLine(base::CommandLine* command_line) override {
- ShelfAppBrowserTestNoDefaultBrowser::SetUpCommandLine(command_line);
- command_line->AppendSwitchASCII("ash-host-window-bounds",
- "800x800,801+0-800x800");
- }
-
- private:
-
- DISALLOW_COPY_AND_ASSIGN(ShelfAppBrowserTestWithMultiMonitor);
-};
-
// Do basic drag and drop interaction tests between the application list and
// the launcher in the secondary monitor.
-// TODO(msw): fix, http://crbug.com/678622.
-IN_PROC_BROWSER_TEST_F(ShelfAppBrowserTestWithMultiMonitor,
- DISABLED_BasicDragAndDrop) {
+IN_PROC_BROWSER_TEST_F(ShelfAppBrowserTest, MultiDisplayBasicDragAndDrop) {
+ // Update the display configuration to add a secondary display.
+ display::test::DisplayManagerTestApi(
+ ash::Shell::GetInstance()->display_manager())
+ .UpdateDisplay("800x800,801+0-800x800");
+
// Get a number of interfaces we need.
DCHECK_EQ(ash::Shell::GetAllRootWindows().size(), 2U);
aura::Window* secondary_root_window = ash::Shell::GetAllRootWindows()[1];
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698