Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 2627983002: Avoid propagating configs across toolchain. (Closed)

Created:
3 years, 11 months ago by sdefresne
Modified:
3 years, 11 months ago
Reviewers:
brettw
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid propagating configs across toolchain. gn will be modified to no longer propagate public_configs across toolchains (as this is a problem with some platforms). Refactor ios_framework_bundle template to define the configs for all the toolchains and to put the references directly (instead of having secondary toolchain get them through the dependency). BUG=675224 Review-Url: https://codereview.chromium.org/2627983002 Cr-Commit-Position: refs/heads/master@{#442967} Committed: https://chromium.googlesource.com/chromium/src/+/72c855683a26d8290f0366a06455d7ec38283aae

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -35 lines) Patch
M build/config/ios/rules.gni View 9 chunks +54 lines, -35 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
sdefresne
Please take a look. This should unblock the gn roll (at least it builds locally ...
3 years, 11 months ago (2017-01-11 16:38:16 UTC) #4
brettw
lgtm
3 years, 11 months ago (2017-01-11 18:40:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627983002/1
3 years, 11 months ago (2017-01-11 18:45:29 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 18:51:24 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/72c855683a26d8290f0366a06455...

Powered by Google App Engine
This is Rietveld 408576698