Avoid propagating configs across toolchain.

build/config/ios/rules.gni

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/ios/ios_sdk.gni")
 import("//build/config/mac/base_rules.gni")
 import("//build/config/mac/symbols.gni")
 import("//build/toolchain/toolchain.gni")
 
 # Invokes lipo on multiple arch-specific binaries to create a fat binary.
@@ skipping 979 matching lines @@
 template("ios_framework_bundle") {
   _target_name = target_name
   _output_name = target_name
   if (defined(invoker.output_name)) {
     _output_name = invoker.output_name
   }
 
   _has_public_headers =
       defined(invoker.public_headers) && invoker.public_headers != []
 
+  # Public configs are not propagated across toolchain (see crbug.com/675224)
+  # so some configs have to be defined for both default_toolchain and all others
+  # toolchains when performing a fat build. Use "get_label_info" to construct
+  # the path since they need to be relative to the default_toolchain.
+
+  _default_toolchain_root_out_dir =
+      get_label_info("$_target_name($default_toolchain)", "root_out_dir")
+  _default_toolchain_target_gen_dir =
+      get_label_info("$_target_name($default_toolchain)", "target_gen_dir")
+
   if (_has_public_headers) {
     _framework_headers_target = _target_name + "_framework_headers"
     _framework_headers_config = _target_name + "_framework_headers_config"
+    config(_framework_headers_config) {
+      # The link settings are inherited from the framework_bundle config.
+      cflags = [
+        "-F",
+        rebase_path("$_default_toolchain_root_out_dir/.", root_build_dir),
+      ]
+    }
+
     _headers_map_config = _target_name + "_headers_map"
+    _header_map_filename =
+        "$_default_toolchain_target_gen_dir/$_output_name.headers.hmap"
+    config(_headers_map_config) {
+      visibility = [ ":$_target_name" ]
+      include_dirs = [ _header_map_filename ]
+    }
   }
 
   _arch_shared_library_source = _target_name + "_arch_shared_library_sources"
   _arch_shared_library_target = _target_name + "_arch_shared_library"
   _lipo_shared_library_target = _target_name + "_shared_library"
+  _link_target_name = _target_name + "+link"
+
+  _framework_public_config = _target_name + "_public_config"
+  config(_framework_public_config) {
+    # TODO(sdefresne): should we have a framework_dirs similar to lib_dirs
+    # and include_dirs to avoid duplicate values on the command-line.
+    visibility = [ ":$_target_name" ]
+    ldflags = [
+      "-F",
+      rebase_path("$_default_toolchain_root_out_dir/.", root_build_dir),
+    ]
+    lib_dirs = [ root_out_dir ]
+    libs = [ "$_output_name.framework" ]
+  }
 
   source_set(_arch_shared_library_source) {
     forward_variables_from(invoker,
                            "*",
                            [
                              "bundle_deps",
                              "bundle_deps_filter",
                              "data_deps",
                              "enable_code_signing",
                              "info_plist",
                              "info_plist_target",
                              "output_name",
                              "visibility",
                            ])
 
     visibility = [ ":$_arch_shared_library_target" ]
 
     if (_has_public_headers) {
       configs += [
-        ":$_framework_headers_config($default_toolchain)",
-        ":$_headers_map_config($default_toolchain)",
+        ":$_framework_headers_config",
+        ":$_headers_map_config",
       ]
 
       if (!defined(deps)) {
         deps = []
       }
       deps += [ ":$_framework_headers_target($default_toolchain)" ]
     }
   }
 
   shared_library(_arch_shared_library_target) {
@@ skipping 50 matching lines @@
       forward_variables_from(invoker,
                              [
                                "visibility",
                                "testonly",
                              ])
       public_deps = [
         ":$_arch_shared_library_target",
       ]
     }
 
-    group(_target_name + "+link") {
+    group(_link_target_name) {
       forward_variables_from(invoker,
                              [
+                               "public_configs",
                                "visibility",
                                "testonly",
                              ])
       public_deps = [
-        ":$_target_name+link($default_toolchain)",
+        ":$_link_target_name($default_toolchain)",
       ]
+
+      if (!defined(public_configs)) {
+        public_configs = []
+      }
+      public_configs += [ ":$_framework_public_config" ]
+      if (_has_public_headers) {
+        public_configs += [ ":$_framework_headers_config" ]
+      }
     }
 
     if (defined(invoker.bundle_deps)) {
       assert(invoker.bundle_deps != [], "mark bundle_deps as used")
     }
   } else {
     if (_has_public_headers) {
       _public_headers = invoker.public_headers
       _framework_root = "$root_out_dir/$_output_name.framework"
 
-      _header_map_filename = "$target_gen_dir/$_output_name.headers.hmap"
-
       _compile_headers_map_target = _target_name + "_compile_headers_map"
       action(_compile_headers_map_target) {
         visibility = [ ":$_framework_headers_target" ]
         script = "//build/config/ios/write_framework_hmap.py"
         outputs = [
           _header_map_filename,
         ]
 
         # The header map generation only wants the list of headers, not all of
         # sources, so filter any non-header source files from "sources". It is
@@ skipping 27 matching lines @@
 
       _copy_public_headers_target = _target_name + "_copy_public_headers"
       copy(_copy_public_headers_target) {
         visibility = [ ":$_framework_headers_target" ]
         sources = _public_headers
         outputs = [
           "$_framework_root/Headers/{{source_file_part}}",
         ]
       }
 
-      config(_headers_map_config) {
-        visibility = [ ":$_target_name" ]
-        include_dirs = [ _header_map_filename ]
-      }
-
       group(_framework_headers_target) {
         deps = [
           ":$_compile_headers_map_target",
           ":$_copy_public_headers_target",
           ":$_create_module_map_target",
         ]
       }
-
-      config(_framework_headers_config) {
-        # The link settings are inherited from the framework_bundle config.
-        cflags = [
-          "-F",
-          rebase_path("$root_out_dir/.", root_build_dir),
-        ]
-      }
     }
 
     lipo_binary(_lipo_shared_library_target) {
       forward_variables_from(invoker,
                              [
                                "configs",
                                "testonly",
                              ])
 
       visibility = [ ":$_target_name" ]
       output_name = _output_name
       arch_binary_target = ":$_arch_shared_library_target"
       arch_binary_output = _output_name
     }
 
-    _framework_public_config = _target_name + "_public_config"
-    config(_framework_public_config) {
-      # TODO(sdefresne): should we have a framework_dirs similar to lib_dirs
-      # and include_dirs to avoid duplicate values on the command-line.
-      visibility = [ ":$_target_name" ]
-      ldflags = [
-        "-F",
-        rebase_path("$root_out_dir/.", root_build_dir),
-      ]
-      lib_dirs = [ root_out_dir ]
-      libs = [ "$_output_name.framework" ]
-    }
-
     _info_plist_target = _target_name + "_info_plist"
     _info_plist_bundle = _target_name + "_info_plist_bundle"
     ios_info_plist(_info_plist_target) {
       visibility = [ ":$_info_plist_bundle" ]
       executable_name = _output_name
       forward_variables_from(invoker,
                              [
                                "extra_substitutions",
                                "info_plist",
                                "info_plist_target",
@@ skipping 32 matching lines @@
       output_name = _output_name
       bundle_binary_target = ":$_lipo_shared_library_target"
       bundle_binary_output = _output_name
 
       if (!defined(deps)) {
         deps = []
       }
       deps += [ ":$_info_plist_bundle" ]
     }
 
-    group(_target_name + "+link") {
+    group(_link_target_name) {
       forward_variables_from(invoker,
                              [
+                               "public_configs",
                                "public_deps",
-                               "public_configs",
                                "testonly",
                                "visibility",
                              ])
       if (!defined(public_deps)) {
         public_deps = []
       }
       public_deps += [ ":$_target_name" ]
+
       if (!defined(public_configs)) {
         public_configs = []
       }
       public_configs += [ ":$_framework_public_config" ]
-
       if (_has_public_headers) {
         public_configs += [ ":$_framework_headers_config" ]
       }
     }
 
     bundle_data(_target_name + "+bundle") {
       forward_variables_from(invoker,
                              [
                                "testonly",
                                "visibility",
@@ skipping 169 matching lines @@
       "-rpath",
       "-Xlinker",
       "@loader_path/Frameworks",
     ]
   }
 }
 
 set_defaults("ios_xctest_test") {
   configs = default_executable_configs
 }