Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2627963003: Add a group to sync-related Android notifications (Closed)

Created:
3 years, 11 months ago by Peter Beverloo
Modified:
3 years, 11 months ago
Reviewers:
maxbogue, awdf, nyquist
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org, sync-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a group to sync-related Android notifications This will avoid the system from inappropriately coalescing them with other kinds of notifications shown by Chrome. BUG=674927 Review-Url: https://codereview.chromium.org/2627963003 Cr-Commit-Position: refs/heads/master@{#443223} Committed: https://chromium.googlesource.com/chromium/src/+/91a4892f8e93dd9328e4079197404c06bcd401b7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/sync/SyncNotificationController.java View 2 chunks +5 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (4 generated)
Peter Beverloo
+awdf, maxbogue
3 years, 11 months ago (2017-01-11 18:55:05 UTC) #2
nyquist
lgtm
3 years, 11 months ago (2017-01-11 18:57:02 UTC) #3
awdf
lgtm, thanks for splitting this out :)
3 years, 11 months ago (2017-01-12 10:41:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627963003/1
3 years, 11 months ago (2017-01-12 13:55:34 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 14:31:18 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/91a4892f8e93dd9328e407919740...

Powered by Google App Engine
This is Rietveld 408576698