Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3624)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/sync/SyncNotificationController.java

Issue 2627963003: Add a group to sync-related Android notifications (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/sync/SyncNotificationController.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/sync/SyncNotificationController.java b/chrome/android/java/src/org/chromium/chrome/browser/sync/SyncNotificationController.java
index 6821bb63fd7a5968dfc5d49330250187e183a4ed..90bbd5a4ac2c73df8e3698528a425c89b333a723 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/sync/SyncNotificationController.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/sync/SyncNotificationController.java
@@ -97,6 +97,9 @@ public class SyncNotificationController implements ProfileSyncService.SyncStateC
+ mApplicationContext.getString(message);
PendingIntent contentIntent = PendingIntent.getActivity(mApplicationContext, 0, intent, 0);
+
+ // There is no need to provide a group summary notification because the NOTIFICATION_ID_SYNC
+ // notification id ensures there's only one sync notification at a time.
NotificationCompat.Builder builder = new NotificationCompat.Builder(mApplicationContext)
.setAutoCancel(true)
.setContentIntent(contentIntent)
@@ -104,7 +107,8 @@ public class SyncNotificationController implements ProfileSyncService.SyncStateC
.setContentText(text)
.setSmallIcon(R.drawable.ic_chrome)
.setTicker(text)
- .setLocalOnly(true);
+ .setLocalOnly(true)
+ .setGroup(NotificationConstants.GROUP_SYNC);
Notification notification =
new NotificationCompat.BigTextStyle(builder).bigText(text).build();
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698